Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 705373004: Don't require getPropertyCSSValue in svg number animation tests (Closed)

Created:
6 years, 1 month ago by Timothy Loh
Modified:
6 years, 1 month ago
CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, dstockwell, Timothy Loh, darktears, Steve Block, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Don't require getPropertyCSSValue in svg number animation tests As getPropertyCSSValue is no longer web-exposed we shouldn't require it in tests so we can delete the interface. BUG=428595 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185010

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -32 lines) Patch
M LayoutTests/svg/animations/script-tests/svgnumber-animation-1.js View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/svg/animations/script-tests/svgnumber-animation-2.js View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/svg/animations/script-tests/svgnumber-animation-3.js View 1 chunk +6 lines, -14 lines 0 comments Download
M LayoutTests/svg/animations/svgnumber-animation-1-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/svg/animations/svgnumber-animation-2-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/svg/animations/svgnumber-animation-3-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Timothy Loh
6 years, 1 month ago (2014-11-08 02:24:31 UTC) #2
alancutter (OOO until 2018)
lgtm
6 years, 1 month ago (2014-11-08 22:02:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/705373004/1
6 years, 1 month ago (2014-11-08 22:02:59 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-08 23:42:52 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 185010

Powered by Google App Engine
This is Rietveld 408576698