Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: LayoutTests/svg/animations/script-tests/svgnumber-animation-3.js

Issue 705373004: Don't require getPropertyCSSValue in svg number animation tests (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/svg/animations/script-tests/svgnumber-animation-3.js
diff --git a/LayoutTests/svg/animations/script-tests/svgnumber-animation-3.js b/LayoutTests/svg/animations/script-tests/svgnumber-animation-3.js
index 6e142612ee740e013533471fce0e0f454a1b22a5..6b1d49d942ae729bce96f4b6e63da68b9f00c58c 100644
--- a/LayoutTests/svg/animations/script-tests/svgnumber-animation-3.js
+++ b/LayoutTests/svg/animations/script-tests/svgnumber-animation-3.js
@@ -22,26 +22,18 @@ rect.appendChild(animate);
rootSVGElement.appendChild(rect);
// Setup animation test
-function sample1() {
+function sample() {
// Check initial/end conditions
- shouldBe("getComputedStyle(rect).getPropertyCSSValue('opacity').getFloatValue(CSSPrimitiveValue.CSS_NUMBER)", "0");
-}
-
-function sample2() {
- shouldBe("getComputedStyle(rect).getPropertyCSSValue('opacity').getFloatValue(CSSPrimitiveValue.CSS_NUMBER)", "0");
-}
-
-function sample3() {
- shouldBe("getComputedStyle(rect).getPropertyCSSValue('opacity').getFloatValue(CSSPrimitiveValue.CSS_NUMBER)", "0");
+ shouldBe("getComputedStyle(rect).opacity", "'0'");
}
function executeTest() {
const expectedValues = [
// [animationId, time, sampleCallback]
- ["animation", 0.0, sample1],
- ["animation", 2.0, sample2],
- ["animation", 3.999, sample3],
- ["animation", 4.001, sample1]
+ ["animation", 0.0, sample],
+ ["animation", 2.0, sample],
+ ["animation", 3.999, sample],
+ ["animation", 4.001, sample]
];
runAnimationTest(expectedValues);

Powered by Google App Engine
This is Rietveld 408576698