LayoutTests/svg/animations/script-tests/svgnumber-animation-2.js - Issue 705373004: Don't require getPropertyCSSValue in svg number animation tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/svg/animations/script-tests/svgnumber-animation-2.js

Issue 705373004: Don't require getPropertyCSSValue in svg number animation tests (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/svg/animations/script-tests/svgnumber-animation-1.js ('k') | LayoutTests/svg/animations/script-tests/svgnumber-animation-3.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/svg/animations/script-tests/svgnumber-animation-2.js

diff --git a/LayoutTests/svg/animations/script-tests/svgnumber-animation-2.js b/LayoutTests/svg/animations/script-tests/svgnumber-animation-2.js

index eb81a668d6b041ded3fd898811ff118cb6d86599..e237861cde36c449a40cc7036a265661b1c2a162 100644

--- a/LayoutTests/svg/animations/script-tests/svgnumber-animation-2.js

+++ b/LayoutTests/svg/animations/script-tests/svgnumber-animation-2.js

@@ -24,15 +24,15 @@ rootSVGElement.appendChild(rect);

// Setup animation test

function sample1() {

// Check initial/end conditions

- shouldBeCloseEnough("getComputedStyle(rect).getPropertyCSSValue('opacity').getFloatValue(CSSPrimitiveValue.CSS_NUMBER)", "0");

+ shouldBeCloseEnough("parseFloat(getComputedStyle(rect).opacity)", "0");

}

function sample2() {

- shouldBeCloseEnough("getComputedStyle(rect).getPropertyCSSValue('opacity').getFloatValue(CSSPrimitiveValue.CSS_NUMBER)", "0.5");

+ shouldBeCloseEnough("parseFloat(getComputedStyle(rect).opacity)", "0.5");

}

function sample3() {

- shouldBeCloseEnough("getComputedStyle(rect).getPropertyCSSValue('opacity').getFloatValue(CSSPrimitiveValue.CSS_NUMBER)", "1");

+ shouldBeCloseEnough("parseFloat(getComputedStyle(rect).opacity)", "1");

}

function executeTest() {