Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 704603002: Move scroll elasticity files from blink to content (Closed)

Created:
6 years, 1 month ago by ccameron
Modified:
6 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jdduke+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move scroll elasticity files from blink to content These will be converted to Chromium style in a follow-on patch. BUG=133097 NOTRY=True (this fails presubmit because of formatting errors) R=aelias@chromium.org, boliu@chromium.org Committed: https://crrev.com/5fa344e7d7015037caf2d18fec02d878685c2d79 Cr-Commit-Position: refs/heads/master@{#302759}

Patch Set 1 #

Patch Set 2 : Un-break checkdeps #

Patch Set 3 : Add whitelist #

Unified diffs Side-by-side diffs Delta from patch set Stats (+589 lines, -0 lines) Patch
M android_webview/tools/third_party_files_whitelist.txt View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A content/renderer/input/input_scroll_elasticity_controller.h View 1 1 chunk +141 lines, -0 lines 0 comments Download
A content/renderer/input/input_scroll_elasticity_controller.cc View 1 1 chunk +445 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (8 generated)
ccameron
6 years, 1 month ago (2014-11-04 21:22:47 UTC) #2
aelias_OOO_until_Jul13
lgtm. I guess it makes sense to copy them without change to provide a baseline ...
6 years, 1 month ago (2014-11-04 21:25:00 UTC) #3
ccameron
Thanks!
6 years, 1 month ago (2014-11-04 21:29:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/704603002/1
6 years, 1 month ago (2014-11-04 21:31:33 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/22112)
6 years, 1 month ago (2014-11-04 21:38:02 UTC) #8
ccameron
On 2014/11/04 21:38:02, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 1 month ago (2014-11-04 22:12:00 UTC) #9
ccameron
Adding boliu to stamp the android_webview changes.
6 years, 1 month ago (2014-11-04 23:05:00 UTC) #11
boliu
lgtm
6 years, 1 month ago (2014-11-04 23:05:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/704603002/40001
6 years, 1 month ago (2014-11-05 00:05:29 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/22157)
6 years, 1 month ago (2014-11-05 00:12:50 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/704603002/40001
6 years, 1 month ago (2014-11-05 00:42:22 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/22172)
6 years, 1 month ago (2014-11-05 00:47:48 UTC) #20
ccameron
Committed patchset #3 (id:40001) manually as 5fa344e7d7015037caf2d18fec02d878685c2d79 (presubmit successful).
6 years, 1 month ago (2014-11-05 06:50:38 UTC) #21
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 06:51:00 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5fa344e7d7015037caf2d18fec02d878685c2d79
Cr-Commit-Position: refs/heads/master@{#302759}

Powered by Google App Engine
This is Rietveld 408576698