Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 704563004: Revert of Add mock context and use in ResourceCacheTest. (Closed)

Created:
6 years, 1 month ago by bsalomon
Modified:
6 years, 1 month ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of Add mock context and use in ResourceCacheTest. (patchset #4 id:60001 of https://codereview.chromium.org/702083003/) Reason for revert: Breaking tests Original issue's description: > Add mock context and use in ResourceCacheTest. > > BUG=skia:2889 > > Committed: https://skia.googlesource.com/skia/+/820dd6c335411aad889c1d7e8a857642ecd87e30 TBR=robertphillips@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2889 Committed: https://skia.googlesource.com/skia/+/fdcf2c0863cdd5779bd6203d45b77d2daf21f159

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -246 lines) Patch
M include/gpu/GrContext.h View 2 chunks +0 lines, -7 lines 0 comments Download
M src/gpu/GrContext.cpp View 3 chunks +9 lines, -11 lines 0 comments Download
M src/gpu/GrTest.cpp View 1 chunk +0 lines, -135 lines 0 comments Download
M tests/ResourceCacheTest.cpp View 10 chunks +76 lines, -93 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bsalomon
Created Revert of Add mock context and use in ResourceCacheTest.
6 years, 1 month ago (2014-11-05 20:29:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/704563004/1
6 years, 1 month ago (2014-11-05 20:30:22 UTC) #2
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 20:30:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as fdcf2c0863cdd5779bd6203d45b77d2daf21f159

Powered by Google App Engine
This is Rietveld 408576698