Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 70443002: Override drawRRect in fake SkBitmapDevices. (Closed)

Created:
7 years, 1 month ago by scroggo
Modified:
7 years, 1 month ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Override drawRRect in fake SkBitmapDevices. Recent changes to SkBitmapDevice modified ::drawRRect() to take an optimized drawing case. Some subclasses of SkBitmapDevice were depending on the old behavior of calling ::drawPath(). Since they do not draw, attempting to take the drawing path can cause problems. For these subclasses, call drawPath() in the subclass. R=reed@google.com, robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=12247

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M include/device/xps/SkXPSDevice.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/device/xps/SkXPSDevice.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M src/utils/SkPictureUtils.cpp View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scroggo
7 years, 1 month ago (2013-11-12 16:52:28 UTC) #1
robertphillips
lgtm
7 years, 1 month ago (2013-11-12 16:57:56 UTC) #2
reed1
lgtm
7 years, 1 month ago (2013-11-12 17:06:43 UTC) #3
scroggo
7 years, 1 month ago (2013-11-12 17:10:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r12247 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698