Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 7044063: Merge 88406 - Mac: Fix icons in download dom UI (Closed)

Created:
9 years, 6 months ago by sail
Modified:
9 years, 6 months ago
Reviewers:
sail
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Merge 88406 - Mac: Fix icons in download dom UI Icons in the download DOM UI were very fuzzy. This was a regression due to r76743. The problem was that IconLoad was returning a multi-resolution image but callers weren't multi-resolution aware. For example, the download DOM UI would encode the image to PNG but it would just pick the first bitmap which happened to be 16x16. This caused icons in the DOM UI to look fuzzy. I think there are two fixes for this: 1. Change IconLoader so that callers no longer specify the icon size. Instead, callers must pick the right resolution when they get the icon loaded callback. 2. Have callers specify that they want all resolutions. I went with 2 because always loading all icon sizes can be expensive. BUG=84741 TEST=Ran and verified that the downloads UI looks good. Review URL: http://codereview.chromium.org/6995068 TBR=sail@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88410

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -12 lines) Patch
M chrome/browser/icon_loader.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/icon_loader_linux.cc View 1 chunk +14 lines, -6 lines 0 comments Download
M chrome/browser/icon_loader_mac.mm View 1 chunk +18 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/download/download_item_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
sail
9 years, 6 months ago (2011-06-08 21:36:40 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698