Mac: Fix icons in download dom UI

Mac: Fix icons in download dom UI

Icons in the download DOM UI were very fuzzy.

This was a regression due to r76743.

The problem was that IconLoad was returning a multi-resolution image but callers weren't multi-resolution aware.

For example, the download DOM UI would encode the image to PNG but it would just pick the first bitmap which happened to be 16x16. This caused icons in the DOM UI to look fuzzy.

I think there are two fixes for this:
1. Change IconLoader so that callers no longer specify the icon size. Instead, callers must pick the right resolution when they get the icon loaded callback.
2. Have callers specify that they want all resolutions.

I went with 2 because always loading all icon sizes can be expensive.

BUG=84741
TEST=Ran and verified that the downloads UI looks good.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88406

[Robert Sesek, 2011-06-08 12:57:31]

http://codereview.chromium.org/6995068/diff/1/chrome/browser/icon_loader.h
File chrome/browser/icon_loader.h (right):

http://codereview.chromium.org/6995068/diff/1/chrome/browser/icon_loader.h#ne...
chrome/browser/icon_loader.h:43: LARGE,
Do you happen to know what 'large' means? 48? Can you add a comment for that,
too?

http://codereview.chromium.org/6995068/diff/1/chrome/browser/icon_loader_mac.mm
File chrome/browser/icon_loader_mac.mm (right):

http://codereview.chromium.org/6995068/diff/1/chrome/browser/icon_loader_mac....
chrome/browser/icon_loader_mac.mm:35: image_.reset(new gfx::Image(new SkBitmap(
Why go through Skia? Can't this be done the Cocoa way?

[sail, 2011-06-08 19:23:42]

http://codereview.chromium.org/6995068/diff/1/chrome/browser/icon_loader.h
File chrome/browser/icon_loader.h (right):

http://codereview.chromium.org/6995068/diff/1/chrome/browser/icon_loader.h#ne...
chrome/browser/icon_loader.h:43: LARGE,
On 2011/06/08 12:57:31, rsesek wrote:
> Do you happen to know what 'large' means? 48? Can you add a comment for that,
> too?

Done.

http://codereview.chromium.org/6995068/diff/1/chrome/browser/icon_loader_mac.mm
File chrome/browser/icon_loader_mac.mm (right):

http://codereview.chromium.org/6995068/diff/1/chrome/browser/icon_loader_mac....
chrome/browser/icon_loader_mac.mm:35: image_.reset(new gfx::Image(new SkBitmap(
On 2011/06/08 12:57:31, rsesek wrote:
> Why go through Skia? Can't this be done the Cocoa way?

Do you mean doing -[NSImage setSize:]? If so that doesn't help in this case
since gfx::Image will still just grab the first NSImageRep from the image when
the caller converts it to a SkBitmap.

There are a couple of advantages to converting to SkBitmap now instead of later:
- we know the requested size so we can get NSImage to create a rendering at the
size that we want
- conversion to SkBitmap can be expensive so its better to do this here than
block the caller's UI thread

[Robert Sesek, 2011-06-08 20:09:48]

LGTM

http://codereview.chromium.org/6995068/diff/1/chrome/browser/icon_loader_mac.mm
File chrome/browser/icon_loader_mac.mm (right):

http://codereview.chromium.org/6995068/diff/1/chrome/browser/icon_loader_mac....
chrome/browser/icon_loader_mac.mm:35: image_.reset(new gfx::Image(new SkBitmap(
On 2011/06/08 19:23:42, sail wrote:
> On 2011/06/08 12:57:31, rsesek wrote:
> > Why go through Skia? Can't this be done the Cocoa way?
> 
> Do you mean doing -[NSImage setSize:]? If so that doesn't help in this case
> since gfx::Image will still just grab the first NSImageRep from the image when
> the caller converts it to a SkBitmap.

Yes, but you could pull out an individual representation and create a new
NSImage with it.

> There are a couple of advantages to converting to SkBitmap now instead of
later:
> - we know the requested size so we can get NSImage to create a rendering at
the
> size that we want
> - conversion to SkBitmap can be expensive so its better to do this here than
> block the caller's UI thread

Both of these sound like good reasons to keep this. Ignore my comment.

[commit-bot: I haz the power, 2011-06-08 21:26:33]

Change committed as 88406