Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 704333002: Add MinidumpRVAListWriter and test (Closed)

Created:
6 years, 1 month ago by Mark Mentovai
Modified:
6 years, 1 month ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@minidump_location_descriptor_list
Project:
crashpad
Visibility:
Public.

Description

Add MinidumpRVAListWriter and test. This will be used as the foundation for writing a list of MinidumpUTF8String objects. MinidumpUTF8String (and UTF-16 MINIDUMP_STRING) objects are never referenced by MINIDUMP_LOCATION_DESCRIPTOR because they carry their own lengths. Instead, they are always referenced by RVA. The list of MinidumpUTF8String objects will be used for the module annotations vector. TEST=minidump_test MinidumpRVAListWriter.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/a980409288f7831ec948d08e66729100fdf4d398

Patch Set 1 #

Patch Set 2 : Put MinidumpRVAListAtStart() into a minidump/test utility #

Patch Set 3 : Rebase, and apply review feedback from https://codereview.chromium.org/707543002/ #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+426 lines, -25 lines) Patch
M minidump/minidump.gyp View 1 3 chunks +5 lines, -0 lines 0 comments Download
M minidump/minidump_extensions.h View 1 chunk +9 lines, -0 lines 0 comments Download
M minidump/minidump_location_descriptor_list_writer_test.cc View 1 2 2 chunks +1 line, -25 lines 0 comments Download
A minidump/minidump_rva_list_writer.h View 1 2 3 1 chunk +78 lines, -0 lines 0 comments Download
A minidump/minidump_rva_list_writer.cc View 1 2 3 1 chunk +97 lines, -0 lines 0 comments Download
A minidump/minidump_rva_list_writer_test.cc View 1 2 1 chunk +101 lines, -0 lines 0 comments Download
A minidump/test/minidump_rva_list_test_util.h View 1 1 chunk +44 lines, -0 lines 0 comments Download
A minidump/test/minidump_rva_list_test_util.cc View 1 2 3 1 chunk +48 lines, -0 lines 0 comments Download
M minidump/test/minidump_writable_test_util.h View 1 2 3 chunks +26 lines, -0 lines 0 comments Download
M minidump/test/minidump_writable_test_util.cc View 1 2 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Mark Mentovai
6 years, 1 month ago (2014-11-06 17:38:29 UTC) #2
Mark Mentovai
This builds on (and updates) https://codereview.chromium.org/707543002/, and makes use of (but does not strictly require) ...
6 years, 1 month ago (2014-11-06 17:39:09 UTC) #3
Mark Mentovai
Updated to rebase and integrate review feedback from https://codereview.chromium.org/704333002.
6 years, 1 month ago (2014-11-06 21:54:56 UTC) #4
Robert Sesek
LGTM
6 years, 1 month ago (2014-11-07 14:42:32 UTC) #5
Mark Mentovai
6 years, 1 month ago (2014-11-07 14:44:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
a980409288f7831ec948d08e66729100fdf4d398 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698