Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: minidump/minidump_location_descriptor_list_writer_test.cc

Issue 704333002: Add MinidumpRVAListWriter and test (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@minidump_location_descriptor_list
Patch Set: Rebase Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « minidump/minidump_extensions.h ('k') | minidump/minidump_rva_list_writer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: minidump/minidump_location_descriptor_list_writer_test.cc
diff --git a/minidump/minidump_location_descriptor_list_writer_test.cc b/minidump/minidump_location_descriptor_list_writer_test.cc
index e193078b1ff9c4c6957191ae045883450cd15840..f831083c157f41b85b27bf13a741f2ea1f1dec2f 100644
--- a/minidump/minidump_location_descriptor_list_writer_test.cc
+++ b/minidump/minidump_location_descriptor_list_writer_test.cc
@@ -24,30 +24,6 @@ namespace crashpad {
namespace test {
namespace {
-class TestMinidumpWritable final : public internal::MinidumpWritable {
- public:
- explicit TestMinidumpWritable(uint32_t value)
- : MinidumpWritable(),
- value_(value) {
- }
-
- ~TestMinidumpWritable() override {}
-
- protected:
- // MinidumpWritable:
-
- size_t SizeOfObject() override { return sizeof(value_); }
-
- bool WriteObject(FileWriterInterface* file_writer) override {
- return file_writer->Write(&value_, sizeof(value_));
- }
-
- private:
- uint32_t value_;
-
- DISALLOW_COPY_AND_ASSIGN(TestMinidumpWritable);
-};
-
class TestMinidumpLocationDescriptorListWriter final
: public MinidumpLocationDescriptorListWriter {
public:
@@ -58,7 +34,7 @@ class TestMinidumpLocationDescriptorListWriter final
~TestMinidumpLocationDescriptorListWriter() override {}
void AddChild(uint32_t value) {
- auto child = make_scoped_ptr(new TestMinidumpWritable(value));
+ auto child = make_scoped_ptr(new TestUInt32MinidumpWritable(value));
MinidumpLocationDescriptorListWriter::AddChild(child.Pass());
}
« no previous file with comments | « minidump/minidump_extensions.h ('k') | minidump/minidump_rva_list_writer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698