Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 703783002: Bug fix for cull_line in SkDashPathEffect. (Closed)

Created:
6 years, 1 month ago by egdaniel
Modified:
6 years, 1 month ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Bug fix for cull_line in SkDashPathEffect. In cull_line we must also check if both points are the same. Otherwise we fail the assert in the else "SkASSERT(dy && !dx)". This is currently blocking the roll as it fails a webkit test. BUG=skia: Committed: https://skia.googlesource.com/skia/+/21402e3851454e90329bad52893f29959da086f7

Patch Set 1 #

Patch Set 2 : Add test cases to dashing gm #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M expectations/gm/ignored-tests.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
M gm/dashing.cpp View 1 2 chunks +12 lines, -0 lines 0 comments Download
M src/effects/SkDashPathEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkDashPath.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
egdaniel
A fix to Rob's recent cl
6 years, 1 month ago (2014-11-05 02:17:01 UTC) #2
robertphillips
lgtm
6 years, 1 month ago (2014-11-05 12:44:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/703783002/20001
6 years, 1 month ago (2014-11-05 12:45:24 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/590)
6 years, 1 month ago (2014-11-05 12:48:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/703783002/20001
6 years, 1 month ago (2014-11-05 12:52:25 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 13:02:31 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 21402e3851454e90329bad52893f29959da086f7

Powered by Google App Engine
This is Rietveld 408576698