src/utils/SkDashPath.cpp - Issue 703783002: Bug fix for cull_line in SkDashPathEffect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/utils/SkDashPath.cpp

Issue 703783002: Bug fix for cull_line in SkDashPathEffect. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Add test cases to dashing gm Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/utils/SkDashPath.cpp

diff --git a/src/utils/SkDashPath.cpp b/src/utils/SkDashPath.cpp

index 02de98f1d66e162896078bffbca391ae8b21126d..4b2b33d2c4a1bf2ced56dcdd3d13ddf4772a0f29 100644

--- a/src/utils/SkDashPath.cpp

+++ b/src/utils/SkDashPath.cpp

@@ -119,7 +119,7 @@ static bool cull_path(const SkPath& srcPath, const SkStrokeRec& rec,

SkTSwap(minX, maxX);

}

- SkASSERT(minX < maxX);

+ SkASSERT(minX <= maxX);

if (maxX < bounds.fLeft || minX > bounds.fRight) {

return false;

}

« no previous file with comments | « src/effects/SkDashPathEffect.cpp ('k') | no next file » | no next file with comments »