src/effects/SkDashPathEffect.cpp - Issue 703783002: Bug fix for cull_line in SkDashPathEffect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkDashPathEffect.cpp

Issue 703783002: Bug fix for cull_line in SkDashPathEffect. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Add test cases to dashing gm Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkDashPathEffect.cpp

diff --git a/src/effects/SkDashPathEffect.cpp b/src/effects/SkDashPathEffect.cpp

index a053066191e955add6f6b8525a19ebc1c5c90b7e..412965e88356edb7da257046e3fea10995d9fda2 100644

--- a/src/effects/SkDashPathEffect.cpp

+++ b/src/effects/SkDashPathEffect.cpp

@@ -66,7 +66,7 @@ static bool cull_line(SkPoint* pts, const SkStrokeRec& rec,

SkScalar dx = pts[1].x() - pts[0].x();

SkScalar dy = pts[1].y() - pts[0].y();

- if (dx && dy) {

+ if ((dx && dy) || (!dx && !dy)) {

return false;

}

« no previous file with comments | « gm/dashing.cpp ('k') | src/utils/SkDashPath.cpp » ('j') | no next file with comments »