Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(13)

Issue 7037027: Fixes Issues #5751 & #22631: NPObject identity (Closed)

Created:
7 years, 9 months ago by Kelly Norton
Modified:
7 years, 8 months ago
Reviewers:
jam, M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Preserves NPObject identity for objects created in a plugin and passed to JavaScript. BUG=5751, 22631 TEST=ui_tests w/ the addition of newly added NPObjectIdentityTest. Committed http://src.chromium.org/viewvc/chrome?view=rev&revision=86893

Patch Set 1 #

Patch Set 2 : ! #

Patch Set 3 : cleanup #

Patch Set 4 : cleanup #

Patch Set 5 : cleanup #

Patch Set 6 : cleanup #

Patch Set 7 : tests pass #

Patch Set 8 : added test #

Patch Set 9 : cleanup #

Patch Set 10 : Adds missing comments. #

Patch Set 11 : fixes bogus change #

Total comments: 8

Patch Set 12 : updated #

Patch Set 13 : hopefully added base url #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -13 lines) Patch
A chrome/test/data/npapi/npobject_identity.html View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +31 lines, -0 lines 0 comments Download
M chrome/test/ui/npapi_uitest.cc View 1 2 3 4 5 6 7 8 9 1 chunk +10 lines, -0 lines 0 comments Download
M content/plugin/npobject_proxy.cc View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +4 lines, -2 lines 0 comments Download
M content/plugin/npobject_stub.cc View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +5 lines, -1 line 0 comments Download
M content/plugin/npobject_util.cc View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +24 lines, -10 lines 0 comments Download
M content/plugin/plugin_channel_base.h View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +39 lines, -0 lines 0 comments Download
M content/plugin/plugin_channel_base.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +28 lines, -0 lines 0 comments Download
A webkit/plugins/npapi/test/plugin_npobject_identity_test.h View 1 2 3 4 5 6 7 1 chunk +26 lines, -0 lines 0 comments Download
A webkit/plugins/npapi/test/plugin_npobject_identity_test.cc View 1 2 3 4 5 6 7 1 chunk +84 lines, -0 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_test_factory.cc View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Kelly Norton
7 years, 9 months ago (2011-05-20 20:22:40 UTC) #1
jam
thanks a lot for the help :) just some nits also, please keep chromium-reviews@chromium.org CCd ...
7 years, 9 months ago (2011-05-20 23:22:22 UTC) #2
Kelly Norton
http://codereview.chromium.org/7037027/diff/7025/chrome/test/data/npapi/npobject_identity.html File chrome/test/data/npapi/npobject_identity.html (right): http://codereview.chromium.org/7037027/diff/7025/chrome/test/data/npapi/npobject_identity.html#newcode1 chrome/test/data/npapi/npobject_identity.html:1: On 2011/05/20 23:22:22, John Abd-El-Malek wrote: > nit: extra ...
7 years, 9 months ago (2011-05-23 15:02:56 UTC) #3
jam
lgtm
7 years, 9 months ago (2011-05-23 16:32:55 UTC) #4
Kelly Norton
Thanks, Can you land this for me? Or is there now a commit-queue or something ...
7 years, 9 months ago (2011-05-23 17:01:24 UTC) #5
M-A Ruel
This change has no base url so the commit queue cannot handle it. You need ...
7 years, 8 months ago (2011-05-25 16:40:25 UTC) #6
Kelly Norton
I just uploaded a new version of the patch ... how can I tell if ...
7 years, 8 months ago (2011-05-25 19:11:49 UTC) #7
M-A Ruel
On 2011/05/25 19:11:49, Kelly Norton wrote: > I just uploaded a new version of the ...
7 years, 8 months ago (2011-05-25 19:15:09 UTC) #8
Kelly Norton
7 years, 8 months ago (2011-05-25 20:48:28 UTC) #9
Trying again ...
http://codereview.chromium.org/7068022/

I just used gcl this time as git svn started just hanging and I didn't want
to rebuild the git repo again.

/kelly

On Wed, May 25, 2011 at 3:15 PM, <maruel@chromium.org> wrote:

> On 2011/05/25 19:11:49, Kelly Norton wrote:
>
>> I just uploaded a new version of the patch ... how can I tell if I managed
>> to include a base url?
>>
>
> base url cannot be changed since it would be a security issue. The easiest:
>
> # Make sure git is correctly initialized
> git svn info
> # Reset issue number
> git cl issue 0
> # Upload a new issue, notice the review was done on the previous issue
> git cl upload --send-mail -r jam@chromium.org
> # Wait for rubberstamp lgtm
> # Check the commit box.
>
>
> M-A
>
> http://codereview.chromium.org/7037027/
>



-- 
If you received this communication by mistake, you are entitled to one free
ice cream cone on me. Simply print out this email including all relevant
SMTP headers and present them at my desk to claim your creamy treat. We'll
have a laugh at my emailing incompetence, and play a game of ping pong.
(offer may not be valid in all States).

Powered by Google App Engine
This is Rietveld 408576698