Preserves NPObject identity for objects created in a plugin and passed to JavaScript.

Preserves NPObject identity for objects created in a plugin and passed to JavaScript. 

BUG=5751, 22631
TEST=ui_tests w/ the addition of newly added NPObjectIdentityTest.

[Kelly Norton, 2011-05-25 20:46:13]

Trying this again, this time with gcl.

[jam, 2011-05-25 23:19:02]

lgtm

[commit-bot: I haz the power, 2011-05-25 23:19:14]

Presubmit check for 7068022-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  webkit/plugins/npapi/test/plugin_npobject_identity_test.cc, line 47, 83 chars
\
  webkit/plugins/npapi/test/plugin_npobject_identity_test.cc, line 55, 95 chars
\
  content/plugin/plugin_channel_base.cc, line 253, 84 chars \
  content/plugin/plugin_channel_base.cc, line 257, 83 chars \
  content/plugin/plugin_channel_base.cc, line 262, 86 chars

Found line ending with white spaces in:

***************
webkit/plugins/npapi/test/plugin_npobject_identity_test.cc, line 41
content/plugin/plugin_channel_base.cc, line 245
***************

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[Kelly Norton, 2011-05-26 01:06:44]

Formatting issues fixed.

[Kelly Norton, 2011-05-26 15:00:46]

ok, one more lgtm .... hopefully ... fingers crossed.

[commit-bot: I haz the power, 2011-05-26 15:05:20]

Try job failure for 7068022-3005 on linux_clang:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

[Kelly Norton, 2011-05-26 15:09:46]

Sigh ... don't think this is me ....

./content/renderer/media/video_capture_impl_manager.h:45:3: error:
[chromium-style] Complex class/struct needs an explicit out-of-line
destructor.
  struct Device {
  ^


/kelly


On Thu, May 26, 2011 at 11:05 AM, <commit-bot@chromium.org> wrote:

> Try job failure for 7068022-3005 on linux_clang:
>
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...
>
>
> http://codereview.chromium.org/7068022/
>



-- 
If you received this communication by mistake, you are entitled to one free
ice cream cone on me. Simply print out this email including all relevant
SMTP headers and present them at my desk to claim your creamy treat. We'll
have a laugh at my emailing incompetence, and play a game of ping pong.
(offer may not be valid in all States).

[commit-bot: I haz the power, 2011-05-26 18:14:45]

Try job failure for 7068022-3005 on win:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[M-A Ruel, 2011-05-26 18:17:11]

On 2011/05/26 18:14:45, commit-bot wrote:
> Try job failure for 7068022-3005 on win:
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

This is a side effect of try jobs generated by
http://codereview.chromium.org/7077006/. I enqueued your job again.

[commit-bot: I haz the power, 2011-05-26 18:24:41]

Try job failure for 7068022-3005 on win:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...