Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 703593003: Move exports from Document to Module (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
eseidel
CC:
esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Move exports from Document to Module This CL moves the |exports| from Document to the new |Module| interface, matching the spec. Also, the |module| object available to scripts is now really an instance of |Module|. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/74314df7dbde12f11a49fe83ba4cbabe7988416a

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -25 lines) Patch
M sky/engine/bindings/core/v8/ScriptController.h View 2 chunks +2 lines, -2 lines 1 comment Download
M sky/engine/bindings/core/v8/ScriptController.cpp View 3 chunks +16 lines, -15 lines 0 comments Download
M sky/engine/core/app/AbstractModule.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/engine/core/dom/Document.h View 5 chunks +6 lines, -5 lines 0 comments Download
M sky/engine/core/dom/Document.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/core/dom/Document.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/LocalDOMWindow.h View 2 chunks +2 lines, -0 lines 0 comments Download
M sky/engine/core/frame/LocalDOMWindow.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M sky/engine/core/html/imports/HTMLImportChild.h View 2 chunks +3 lines, -0 lines 0 comments Download
M sky/engine/core/html/imports/HTMLImportChild.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M sky/engine/core/html/imports/HTMLImportLoader.h View 3 chunks +4 lines, -0 lines 0 comments Download
M sky/engine/core/html/imports/HTMLImportLoader.cpp View 3 chunks +6 lines, -1 line 0 comments Download
M sky/engine/core/html/parser/HTMLScriptRunner.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + sky/tests/modules/instance-of-application.sky View 1 chunk +1 line, -2 lines 0 comments Download
A + sky/tests/modules/instance-of-application-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A sky/tests/modules/instance-of-module.sky View 1 chunk +8 lines, -0 lines 0 comments Download
A + sky/tests/modules/instance-of-module-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A sky/tests/modules/resources/instance-of-module-module.sky View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
6 years, 1 month ago (2014-11-10 23:00:16 UTC) #1
eseidel
lgtm https://codereview.chromium.org/703593003/diff/1/sky/engine/bindings/core/v8/ScriptController.h File sky/engine/bindings/core/v8/ScriptController.h (right): https://codereview.chromium.org/703593003/diff/1/sky/engine/bindings/core/v8/ScriptController.h#newcode75 sky/engine/bindings/core/v8/ScriptController.h:75: void executeModuleScript(AbstractModule*, const String& source, const TextPosition& textPosition); ...
6 years, 1 month ago (2014-11-10 23:30:19 UTC) #2
abarth-chromium
6 years, 1 month ago (2014-11-10 23:34:29 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
74314df7dbde12f11a49fe83ba4cbabe7988416a.

Powered by Google App Engine
This is Rietveld 408576698