Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1390)

Unified Diff: sky/engine/bindings/core/v8/ScriptController.h

Issue 703593003: Move exports from Document to Module (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/engine/bindings/core/v8/ScriptController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/bindings/core/v8/ScriptController.h
diff --git a/sky/engine/bindings/core/v8/ScriptController.h b/sky/engine/bindings/core/v8/ScriptController.h
index 929268ff908137c0a99693ee64853cd93c7a746d..67f7e1042beedf37f9c31be6dd0219de046c7788 100644
--- a/sky/engine/bindings/core/v8/ScriptController.h
+++ b/sky/engine/bindings/core/v8/ScriptController.h
@@ -44,12 +44,12 @@
namespace blink {
class DOMWrapperWorld;
-class Document;
class ExecutionContext;
class Event;
class HTMLDocument;
class KURL;
class LocalFrame;
+class AbstractModule;
class ScriptState;
class ScriptSourceCode;
class WindowProxy;
@@ -72,7 +72,7 @@ public:
v8::Local<v8::Value> executeScriptInMainWorldAndReturnValue(const ScriptSourceCode&);
v8::Local<v8::Value> executeScriptAndReturnValue(v8::Handle<v8::Context>, const ScriptSourceCode&);
- void executeModuleScript(Document& document, const String& source, const TextPosition& textPosition);
+ void executeModuleScript(AbstractModule*, const String& source, const TextPosition& textPosition);
eseidel 2014/11/10 23:30:19 I would use & based on our in-person discussion.
// Executes JavaScript in an isolated world. The script gets its own global scope,
// its own prototypes for intrinsic JavaScript objects (String, Array, and so-on),
« no previous file with comments | « no previous file | sky/engine/bindings/core/v8/ScriptController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698