Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 703473002: Revert of The name attribute can be from contents for listitem role (Closed)

Created:
6 years, 1 month ago by Hajime Morrita
Modified:
6 years, 1 month ago
CC:
blink-reviews, dmazzoni, aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of The name attribute can be from contents for listitem role (patchset #1 id:1 of https://codereview.chromium.org/696953002/) Reason for revert: This seems breaking AccessibilityAriaList in content_browsertests on Mac. http://build.chromium.org/p/chromium.webkit/builders/Mac10.6%20Tests/builds/27219 http://test-results.appspot.com/dashboards/flakiness_dashboard.html#master=chromium.webkit&testType=content_browsertests&tests=DumpAccessibilityTreeTest.AccessibilityAriaList Original issue's description: > The name attribute can be from contents for listitem role > according to http://www.w3.org/WAI/PF/aria/roles#listitem. > > BUG=347865 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184795 TBR=dmazzoni@chromium.org,je_julie.kim@samsung.com NOTREECHECKS=true NOTRY=true BUG=347865 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184802

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M Source/core/accessibility/AXNodeObject.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Hajime Morrita
Created Revert of The name attribute can be from contents for listitem role
6 years, 1 month ago (2014-11-03 21:52:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/703473002/1
6 years, 1 month ago (2014-11-03 21:53:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 184802
6 years, 1 month ago (2014-11-03 21:53:55 UTC) #3
je_julie(Not used)
6 years, 1 month ago (2014-11-04 02:51:05 UTC) #4
Message was sent while issue was closed.
Hi Morrita,
Thanks for handling it.

Powered by Google App Engine
This is Rietveld 408576698