Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Side by Side Diff: Source/core/accessibility/AXNodeObject.cpp

Issue 703473002: Revert of The name attribute can be from contents for listitem role (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012, Google Inc. All rights reserved. 2 * Copyright (C) 2012, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 1221 matching lines...) Expand 10 before | Expand all | Expand 10 after
1232 1232
1233 switch (roleValue()) { 1233 switch (roleValue()) {
1234 case PopUpButtonRole: 1234 case PopUpButtonRole:
1235 // Native popup buttons should not use their button children's text as a title. That value is retrieved through stringValue(). 1235 // Native popup buttons should not use their button children's text as a title. That value is retrieved through stringValue().
1236 if (isHTMLSelectElement(*node)) 1236 if (isHTMLSelectElement(*node))
1237 return String(); 1237 return String();
1238 case ButtonRole: 1238 case ButtonRole:
1239 case ToggleButtonRole: 1239 case ToggleButtonRole:
1240 case CheckBoxRole: 1240 case CheckBoxRole:
1241 case ListBoxOptionRole: 1241 case ListBoxOptionRole:
1242 case ListItemRole:
1243 case MenuButtonRole: 1242 case MenuButtonRole:
1244 case MenuItemRole: 1243 case MenuItemRole:
1245 case MenuItemCheckBoxRole: 1244 case MenuItemCheckBoxRole:
1246 case MenuItemRadioRole: 1245 case MenuItemRadioRole:
1247 case RadioButtonRole: 1246 case RadioButtonRole:
1248 case TabRole: 1247 case TabRole:
1249 return textUnderElement(); 1248 return textUnderElement();
1250 // SVGRoots should not use the text under itself as a title. That could incl ude the text of objects like <text>. 1249 // SVGRoots should not use the text under itself as a title. That could incl ude the text of objects like <text>.
1251 case SVGRootRole: 1250 case SVGRootRole:
1252 return String(); 1251 return String();
(...skipping 520 matching lines...) Expand 10 before | Expand all | Expand 10 after
1773 float range = maxValueForRange() - minValueForRange(); 1772 float range = maxValueForRange() - minValueForRange();
1774 float value = valueForRange(); 1773 float value = valueForRange();
1775 1774
1776 value += range * (percentChange / 100); 1775 value += range * (percentChange / 100);
1777 setValue(String::number(value)); 1776 setValue(String::number(value));
1778 1777
1779 axObjectCache()->postNotification(node(), AXObjectCacheImpl::AXValueChanged, true); 1778 axObjectCache()->postNotification(node(), AXObjectCacheImpl::AXValueChanged, true);
1780 } 1779 }
1781 1780
1782 } // namespace blink 1781 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698