Issue 703353002: Add MinidumpCrashpadInfoWriter::InitializeFromSnapshot() and its test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 703353002: Add MinidumpCrashpadInfoWriter::InitializeFromSnapshot() and its test (Closed)

Created:
6 years, 1 month ago by Mark Mentovai

Modified:
6 years, 1 month ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@minidump_module_annotations_list

Project:
crashpad

Visibility:
Public.

Add MinidumpCrashpadInfoWriter::InitializeFromSnapshot() and its test. TEST=minidump_test MinidumpCrashpadInfoWriter.InitializeFromSnapshot R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/4a22225fc05026dd1c9c870701de34da57edf68e

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+140 lines, -2 lines)			Patch
M	minidump/minidump_crashpad_info_writer.h	View	3 chunks	+27 lines, -0 lines	0 comments	Download
M	minidump/minidump_crashpad_info_writer.cc	View	3 chunks	+18 lines, -0 lines	0 comments	Download
M	minidump/minidump_crashpad_info_writer_test.cc	View	4 chunks	+73 lines, -0 lines	0 comments	Download
M	minidump/minidump_module_crashpad_info_writer.h	View	2 chunks	+10 lines, -2 lines	0 comments	Download
M	minidump/minidump_module_crashpad_info_writer.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	minidump/minidump_module_crashpad_info_writer_test.cc	View	5 chunks	+8 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Mark Mentovai

This depends loosely on https://codereview.chromium.org/705153002/.

6 years, 1 month ago (2014-11-06 23:05:10 UTC) #2

Mark Mentovai

6 years, 1 month ago (2014-11-07 16:38:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
4a22225fc05026dd1c9c870701de34da57edf68e (presubmit successful).