minidump/minidump_module_crashpad_info_writer.cc - Issue 703353002: Add MinidumpCrashpadInfoWriter::InitializeFromSnapshot() and its test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/minidump_module_crashpad_info_writer.cc

Issue 703353002: Add MinidumpCrashpadInfoWriter::InitializeFromSnapshot() and its test (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@minidump_module_annotations_list

Patch Set: Rebase Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: minidump/minidump_module_crashpad_info_writer.cc

diff --git a/minidump/minidump_module_crashpad_info_writer.cc b/minidump/minidump_module_crashpad_info_writer.cc

index 93da6f0f6a7b7401300672d4104a1041c3d89507..d85685832410401c106efc3eddb36be97eb2aa0a 100644

--- a/minidump/minidump_module_crashpad_info_writer.cc

+++ b/minidump/minidump_module_crashpad_info_writer.cc

@@ -161,4 +161,8 @@ void MinidumpModuleCrashpadInfoListWriter::AddModule(

AddChild(module.Pass());

}

+bool MinidumpModuleCrashpadInfoListWriter::IsUseful() const {

+ return !IsEmpty();

} // namespace crashpad

« no previous file with comments | « minidump/minidump_module_crashpad_info_writer.h ('k') | minidump/minidump_module_crashpad_info_writer_test.cc » ('j') | no next file with comments »