Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: minidump/minidump_module_crashpad_info_writer_test.cc

Issue 703353002: Add MinidumpCrashpadInfoWriter::InitializeFromSnapshot() and its test (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@minidump_module_annotations_list
Patch Set: Rebase Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « minidump/minidump_module_crashpad_info_writer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: minidump/minidump_module_crashpad_info_writer_test.cc
diff --git a/minidump/minidump_module_crashpad_info_writer_test.cc b/minidump/minidump_module_crashpad_info_writer_test.cc
index 47aa760187312fb59af3d615540397a0f21b1113..a798f03f0273e7b90ba513e28ce6be13cbefafba 100644
--- a/minidump/minidump_module_crashpad_info_writer_test.cc
+++ b/minidump/minidump_module_crashpad_info_writer_test.cc
@@ -34,6 +34,7 @@ TEST(MinidumpModuleCrashpadInfoWriter, EmptyList) {
StringFileWriter file_writer;
MinidumpModuleCrashpadInfoListWriter module_list_writer;
+ EXPECT_FALSE(module_list_writer.IsUseful());
EXPECT_TRUE(module_list_writer.WriteEverything(&file_writer));
ASSERT_EQ(sizeof(MinidumpModuleCrashpadInfoList),
@@ -53,6 +54,8 @@ TEST(MinidumpModuleCrashpadInfoWriter, EmptyModule) {
EXPECT_FALSE(module_writer->IsUseful());
module_list_writer.AddModule(module_writer.Pass());
+ EXPECT_TRUE(module_list_writer.IsUseful());
+
EXPECT_TRUE(module_list_writer.WriteEverything(&file_writer));
ASSERT_EQ(sizeof(MinidumpModuleCrashpadInfoList) +
sizeof(MINIDUMP_LOCATION_DESCRIPTOR) +
@@ -105,6 +108,8 @@ TEST(MinidumpModuleCrashpadInfoWriter, FullModule) {
EXPECT_TRUE(module_writer->IsUseful());
module_list_writer.AddModule(module_writer.Pass());
+ EXPECT_TRUE(module_list_writer.IsUseful());
+
EXPECT_TRUE(module_list_writer.WriteEverything(&file_writer));
ASSERT_EQ(sizeof(MinidumpModuleCrashpadInfoList) +
sizeof(MINIDUMP_LOCATION_DESCRIPTOR) +
@@ -213,6 +218,8 @@ TEST(MinidumpModuleCrashpadInfoWriter, ThreeModules) {
EXPECT_TRUE(module_writer_2->IsUseful());
module_list_writer.AddModule(module_writer_2.Pass());
+ EXPECT_TRUE(module_list_writer.IsUseful());
+
EXPECT_TRUE(module_list_writer.WriteEverything(&file_writer));
const MinidumpModuleCrashpadInfoList* module_list =
@@ -335,6 +342,7 @@ TEST(MinidumpModuleCrashpadInfoWriter, InitializeFromSnapshot) {
MinidumpModuleCrashpadInfoListWriter module_list_writer;
module_list_writer.InitializeFromSnapshot(module_snapshots);
+ EXPECT_TRUE(module_list_writer.IsUseful());
StringFileWriter file_writer;
ASSERT_TRUE(module_list_writer.WriteEverything(&file_writer));
« no previous file with comments | « minidump/minidump_module_crashpad_info_writer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698