Issue 70333004: Telemetry: make media perf tests log errors rather than timing out

Issue 70333004: Telemetry: make media perf tests log errors rather than timing out (Closed)

Created:
7 years, 1 month ago by shadi

Modified:
7 years, 1 month ago

Reviewers:
dtu

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Telemetry: make media perf tests log errors rather than timing out BUG=318432 TEST=tools/perf/run_benchmark media.tough_media_cases (with tough_video_cases.json edited to include invalid media URLs) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235672

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -36 lines)			Patch
M	tools/perf/metrics/media.js	View	1	3 chunks	+17 lines, -5 lines	0 comments	Download
M	tools/perf/metrics/media.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/perf/page_sets/tough_video_cases/video.html	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/telemetry/telemetry/page/actions/loop.js	View		2 chunks	+1 line, -5 lines	0 comments	Download
M	tools/telemetry/telemetry/page/actions/media_action.js	View		1 chunk	+21 lines, -0 lines	0 comments	Download
M	tools/telemetry/telemetry/page/actions/media_action.py	View		2 chunks	+13 lines, -4 lines	0 comments	Download
M	tools/telemetry/telemetry/page/actions/play.js	View		1 chunk	+3 lines, -10 lines	0 comments	Download
M	tools/telemetry/telemetry/page/actions/seek.js	View		1 chunk	+3 lines, -11 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

dtu

lgtm Note that failures can skew aggregate results, if you have any. (I don't know ...

7 years, 1 month ago (2013-11-16 00:16:52 UTC) #3

shadi

Thanks for review. You are right, but these tests do not aggregate metrics.

7 years, 1 month ago (2013-11-16 01:23:57 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shadi@chromium.org/70333004/60001

7 years, 1 month ago (2013-11-16 02:00:48 UTC) #5

Message was sent while issue was closed.

Change committed as 235672

Expand Messages | Collapse Messages