Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: tools/telemetry/telemetry/page/actions/play.js

Issue 70333004: Telemetry: make media perf tests log errors rather than timing out (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/actions/play.js
diff --git a/tools/telemetry/telemetry/page/actions/play.js b/tools/telemetry/telemetry/page/actions/play.js
index 80e42c42f6e25e9bd3a8d8026e97f75f5761010f..c646d78ad7a0e7b31c26d676eae33e36cd7941ec 100644
--- a/tools/telemetry/telemetry/page/actions/play.js
+++ b/tools/telemetry/telemetry/page/actions/play.js
@@ -21,16 +21,9 @@
}
function playHTML5Element(element) {
- function logEventHappened(e) {
- element[e.type + '_completed'] = true;
- }
- function onError(e) {
- throw new Error('Error playing media :' + e.type);
- }
- element.addEventListener('playing', logEventHappened);
- element.addEventListener('ended', logEventHappened);
- element.addEventListener('error', onError);
- element.addEventListener('abort', onError);
+ window.__registerHTML5ErrorEvents(element);
+ window.__registerHTML5EventCompleted(element, 'playing');
+ window.__registerHTML5EventCompleted(element, 'ended');
var willPlayEvent = document.createEvent('Event');
willPlayEvent.initEvent('willPlay', false, false);
« no previous file with comments | « tools/telemetry/telemetry/page/actions/media_action.py ('k') | tools/telemetry/telemetry/page/actions/seek.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698