Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: tools/telemetry/telemetry/page/actions/seek.js

Issue 70333004: Telemetry: make media perf tests log errors rather than timing out (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/page/actions/play.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/actions/seek.js
diff --git a/tools/telemetry/telemetry/page/actions/seek.js b/tools/telemetry/telemetry/page/actions/seek.js
index e77d48726db139aacbbdf1eb84fdcd38c4e06ad5..baef30cc77061d9c5edc1f9922bcde43ff1e2637 100644
--- a/tools/telemetry/telemetry/page/actions/seek.js
+++ b/tools/telemetry/telemetry/page/actions/seek.js
@@ -32,18 +32,10 @@
}
function seekHTML5ElementPostLoad(element, seekTime, logSeekTime, seekLabel) {
- var onSeeked = function(e) {
- element[e.type + '_completed'] = true;
- element.removeEventListener('seeked', onSeeked);
- };
- function onError(e) {
- throw new Error('Error playing media :' + e.type);
- }
-
+ // Reset seek completion since multiple seeks can run on same media element.
element['seeked_completed'] = false;
- element.addEventListener('error', onError);
- element.addEventListener('abort', onError);
- element.addEventListener('seeked', onSeeked);
+ window.__registerHTML5ErrorEvents(element);
+ window.__registerHTML5EventCompleted(element, 'seeked');
if (logSeekTime) {
var willSeekEvent = document.createEvent('Event');
« no previous file with comments | « tools/telemetry/telemetry/page/actions/play.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698