Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 703193004: XSLT-in-PrivateScript (Closed)

Created:
6 years, 1 month ago by tasak
Modified:
5 years, 11 months ago
Reviewers:
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, Inactive, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

XSLT-in-PrivateScript This patch needs "deprecating external DTD" and updating grd. BUG=367689

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+300 lines, -116 lines) Patch
M Source/core/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/core.gypi View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/core/core_generated.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/Document.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/dom/Document.cpp View 3 chunks +0 lines, -24 lines 0 comments Download
M Source/core/dom/DocumentStyleSheetCollection.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/ProcessingInstruction.cpp View 6 chunks +9 lines, -7 lines 0 comments Download
M Source/core/dom/ProcessingInstruction.idl View 1 chunk +2 lines, -0 lines 0 comments Download
A Source/core/dom/ProcessingInstruction.js View 1 chunk +167 lines, -0 lines 0 comments Download
M Source/core/dom/ShadowTreeStyleSheetCollection.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/StyleEngine.h View 3 chunks +0 lines, -5 lines 0 comments Download
M Source/core/dom/StyleEngine.cpp View 7 chunks +0 lines, -51 lines 0 comments Download
M Source/core/dom/StyleSheetCandidate.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/StyleSheetCandidate.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/frame/LocalDOMWindow.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/LocalDOMWindow.cpp View 3 chunks +30 lines, -0 lines 0 comments Download
A + Source/core/xml/DocumentXSLT.h View 1 chunk +0 lines, -2 lines 0 comments Download
A + Source/core/xml/DocumentXSLT.idl View 1 chunk +3 lines, -4 lines 0 comments Download
A Source/core/xml/DocumentXSLT.js View 1 chunk +15 lines, -0 lines 0 comments Download
A Source/core/xml/WindowXSLT.h View 1 chunk +21 lines, -0 lines 0 comments Download
A Source/core/xml/WindowXSLT.cpp View 1 chunk +17 lines, -0 lines 0 comments Download
A + Source/core/xml/WindowXSLT.idl View 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/xml/XSLTProcessor.h View 2 chunks +3 lines, -2 lines 1 comment Download
M Source/core/xml/XSLTProcessor.cpp View 2 chunks +7 lines, -2 lines 0 comments Download
M Source/core/xml/parser/XMLDocumentParser.cpp View 2 chunks +10 lines, -2 lines 0 comments Download
M Source/core/xml/parser/XMLErrors.cpp View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
tasak
https://codereview.chromium.org/703193004/diff/1/Source/core/xml/XSLTProcessor.h File Source/core/xml/XSLTProcessor.h (right): https://codereview.chromium.org/703193004/diff/1/Source/core/xml/XSLTProcessor.h#newcode85 Source/core/xml/XSLTProcessor.h:85: void setXSLStyleSheet(PassRefPtrWillBeRawPtr<XSLStyleSheet> styleSheet) { m_stylesheet = styleSheet; } If ...
6 years, 1 month ago (2014-11-07 13:34:55 UTC) #1
vivekg
6 years ago (2014-11-28 13:04:04 UTC) #2 
and this as well:

privateScriptController.installClass :)

We changed this in: https://codereview.chromium.org/756053002

Powered by Google App Engine
This is Rietveld 408576698