Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 756053002: [Blink-in-JS] Migrate the PrivateScript specific methods/attributes to ScriptController (Closed)

Created:
6 years ago by vivekg_samsung
Modified:
6 years ago
Reviewers:
haraken, vivekg
CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[Blink-in-JS] Migrate the PrivateScript specific methods/attributes to ScriptController Migrating the methods such as installClass, import etc. to ScriptController so as not to pollute the global window object. R=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186004

Patch Set 1 #

Patch Set 2 : ScriptController => PrivateScriptController #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -58 lines) Patch
M Source/bindings/core/v8/PrivateScriptRunner.js View 1 2 chunks +61 lines, -42 lines 0 comments Download
M Source/core/html/HTMLMarqueeElement.js View 1 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/shadow/PluginPlaceholderElement.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/PartialPrivateScriptTest.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/PrivateScriptTest.js View 1 2 chunks +9 lines, -9 lines 0 comments Download
M Source/core/xml/DocumentXMLTreeViewer.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
vivekg
@haraken, this is just WIP. Please take a look and let me know your feedback. ...
6 years ago (2014-11-25 14:16:18 UTC) #2
haraken
On 2014/11/25 14:16:18, vivekg_ wrote: > @haraken, this is just WIP. Please take a look ...
6 years ago (2014-11-25 15:36:37 UTC) #3
vivekg
On 2014/11/25 at 15:36:37, haraken wrote: > On 2014/11/25 14:16:18, vivekg_ wrote: > > @haraken, ...
6 years ago (2014-11-26 03:20:16 UTC) #4
haraken
LGTM
6 years ago (2014-11-26 03:26:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/756053002/20001
6 years ago (2014-11-26 03:30:35 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/38514)
6 years ago (2014-11-26 05:16:46 UTC) #9
vivekg
On 2014/11/26 at 05:16:46, commit-bot wrote: > Try jobs failed on following builders: > win_blink_rel ...
6 years ago (2014-11-26 05:19:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/756053002/20001
6 years ago (2014-11-26 05:20:01 UTC) #12
commit-bot: I haz the power
6 years ago (2014-11-26 06:39:57 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186004

Powered by Google App Engine
This is Rietveld 408576698