Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 702863003: [Telemetry] Fix profiler bug, add unittest for profiling flag (Closed)

Created:
6 years, 1 month ago by nednguyen
Modified:
6 years, 1 month ago
Reviewers:
dtu, chrishenry, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Fix profiler bug, add unittest for profiling flag BUG=430246 Committed: https://crrev.com/2ee1e3b6643f5ba581ad5411870466a5cf9d7bba Cr-Commit-Position: refs/heads/master@{#302867}

Patch Set 1 #

Patch Set 2 : Add trace file ouput assertion #

Total comments: 1

Patch Set 3 : Address nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
M tools/telemetry/telemetry/page/page_runner.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/page_runner_unittest.py View 1 2 2 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
nednguyen
6 years, 1 month ago (2014-11-05 17:37:08 UTC) #2
nednguyen
6 years, 1 month ago (2014-11-05 17:37:09 UTC) #3
chrishenry
lgtm https://codereview.chromium.org/702863003/diff/20001/tools/telemetry/telemetry/page/page_runner_unittest.py File tools/telemetry/telemetry/page/page_runner_unittest.py (right): https://codereview.chromium.org/702863003/diff/20001/tools/telemetry/telemetry/page/page_runner_unittest.py#newcode674 tools/telemetry/telemetry/page/page_runner_unittest.py:674: nit: 1 blank line. (:
6 years, 1 month ago (2014-11-05 19:09:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/702863003/40001
6 years, 1 month ago (2014-11-05 19:12:12 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-05 21:13:32 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 21:14:29 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/2ee1e3b6643f5ba581ad5411870466a5cf9d7bba
Cr-Commit-Position: refs/heads/master@{#302867}

Powered by Google App Engine
This is Rietveld 408576698