Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: tools/telemetry/telemetry/page/page_runner_unittest.py

Issue 702863003: [Telemetry] Fix profiler bug, add unittest for profiling flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address nit Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/page/page_runner.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/page_runner_unittest.py
diff --git a/tools/telemetry/telemetry/page/page_runner_unittest.py b/tools/telemetry/telemetry/page/page_runner_unittest.py
index 342e912e1fabd5a6fe7be0ac6cd14a97251f6d0f..2826e6c8fff67876f9dadc6251c18b64d1ca3791 100644
--- a/tools/telemetry/telemetry/page/page_runner_unittest.py
+++ b/tools/telemetry/telemetry/page/page_runner_unittest.py
@@ -5,6 +5,7 @@
import os
import tempfile
import unittest
+import shutil
import StringIO
import sys
import tempfile
@@ -670,6 +671,35 @@ class PageRunnerTests(unittest.TestCase):
def testMaxFailuresOptionIsOverridable(self):
self._testMaxFailuresOptionIsRespectedAndOverridable(1)
+ def testRunPageWithProfilingFlag(self):
+ ps = page_set.PageSet()
+ expectations = test_expectations.TestExpectations()
+ ps.pages.append(page_module.Page(
+ 'file://blank.html', ps, base_dir=util.GetUnittestDataDir()))
+
+ class Measurement(page_test.PageTest):
+ pass
+
+ options = options_for_unittests.GetCopy()
+ options.output_formats = ['none']
+ options.suppress_gtest_report = True
+ options.reset_results = None
+ options.upload_results = None
+ options.results_label = None
+ options.output_dir = tempfile.mkdtemp()
+ options.profiler = 'trace'
+ try:
+ SetUpPageRunnerArguments(options)
+ results = results_options.CreateResults(EmptyMetadataForTest(), options)
+ page_runner.Run(Measurement(), ps, expectations, options, results)
+ self.assertEquals(1, len(GetSuccessfulPageRuns(results)))
+ self.assertEquals(0, len(results.failures))
+ self.assertEquals(0, len(results.all_page_specific_values))
+ self.assertTrue(os.path.isfile(
+ os.path.join(options.output_dir, 'blank_html.json')))
+ finally:
+ shutil.rmtree(options.output_dir)
+
class FakeNetworkController(object):
def __init__(self):
« no previous file with comments | « tools/telemetry/telemetry/page/page_runner.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698