tools/telemetry/telemetry/page/page_runner.py - Issue 702863003: [Telemetry] Fix profiler bug, add unittest for profiling flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_runner.py

Issue 702863003: [Telemetry] Fix profiler bug, add unittest for profiling flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address nit Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/page_runner.py

diff --git a/tools/telemetry/telemetry/page/page_runner.py b/tools/telemetry/telemetry/page/page_runner.py

index 207bae7a8ea1e793170ca8dd209ddf4856eb39eb..69a350621814d276dfb06adbfd130925794fd744 100644

--- a/tools/telemetry/telemetry/page/page_runner.py

+++ b/tools/telemetry/telemetry/page/page_runner.py

@@ -62,9 +62,9 @@ class _RunState(object):

return possible_browser

def WillRunPage(self, page):

+ self._current_page = page

if self._finder_options.profiler:

self._StartProfiling(self._current_page)

- self._current_page = page

def DidRunPage(self):

if self._finder_options.profiler:

« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/page_runner_unittest.py » ('j') | no next file with comments »