Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 702603003: DevTools: SourcesPanel: Double-click on watch expression name should start editing. (Closed)

Created:
6 years, 1 month ago by eustas
Modified:
6 years, 1 month ago
Reviewers:
caseq, vsevik, lushnikov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools: SourcesPanel: Double-click on watch expression name should start editing. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184879

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/devtools/front_end/components/ObjectPropertiesSection.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
eustas
6 years, 1 month ago (2014-11-04 17:32:32 UTC) #2
vsevik
This is a regression introduced by https://codereview.chromium.org/656123002. We should check that both bugs are fixed ...
6 years, 1 month ago (2014-11-05 06:54:15 UTC) #3
eustas
On 2014/11/05 06:54:15, vsevik wrote: > This is a regression introduced by https://codereview.chromium.org/656123002. > We ...
6 years, 1 month ago (2014-11-05 15:54:15 UTC) #4
vsevik
lgtm
6 years, 1 month ago (2014-11-05 16:01:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/702603003/1
6 years, 1 month ago (2014-11-05 16:02:18 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 18:15:22 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 184879

Powered by Google App Engine
This is Rietveld 408576698