Source/devtools/front_end/components/ObjectPropertiesSection.js - Issue 702603003: DevTools: SourcesPanel: Double-click on watch expression name should start editing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/components/ObjectPropertiesSection.js

Issue 702603003: DevTools: SourcesPanel: Double-click on watch expression name should start editing. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/devtools/front_end/components/ObjectPropertiesSection.js

diff --git a/Source/devtools/front_end/components/ObjectPropertiesSection.js b/Source/devtools/front_end/components/ObjectPropertiesSection.js

index deb95f32ff4563237136d8c8717165d8fc6e40f7..8ca261bea05e9eca698bcd50497a5220d06b4981 100644

--- a/Source/devtools/front_end/components/ObjectPropertiesSection.js

+++ b/Source/devtools/front_end/components/ObjectPropertiesSection.js

@@ -166,7 +166,8 @@ WebInspector.ObjectPropertyTreeElement.prototype = {

ondblclick: function(event)

{

- if ((this.property.writable || this.property.setter) && event.target.isSelfOrDescendant(this.valueElement))

+ var editableElement = this.elementAndValueToEdit().element;

+ if ((this.property.writable || this.property.setter) && event.target.isSelfOrDescendant(editableElement))

this.startEditing(event);

return false;

« no previous file with comments | « no previous file | no next file » | no next file with comments »