Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 656123002: DevTools: [Console] select property names with double click (Closed)

Created:
6 years, 2 months ago by lushnikov
Modified:
6 years, 1 month ago
Reviewers:
vsevik, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools: [Console] select property names with double click As of today, double click on property name in ObjectPropertyTreeElement results in editing of the property value. The patch changes the behavior so that double click on property name just sets a selection, and one has to double-click on property value to edit it. BUG=423085 R=vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183760

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/devtools/front_end/components/ObjectPropertiesSection.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
lushnikov
зефд
6 years, 2 months ago (2014-10-15 13:34:57 UTC) #1
lushnikov
ptal
6 years, 2 months ago (2014-10-15 13:35:05 UTC) #2
pfeldman
lgtm
6 years, 2 months ago (2014-10-15 14:32:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656123002/1
6 years, 2 months ago (2014-10-15 14:41:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 183760
6 years, 2 months ago (2014-10-15 18:12:21 UTC) #7
eustas
You've broken edit watch expression experience!
6 years, 1 month ago (2014-11-04 16:30:15 UTC) #8
lushnikov
6 years, 1 month ago (2014-11-05 15:46:29 UTC) #9
Message was sent while issue was closed.
On 2014/11/04 16:30:15, eustas wrote:
> You've broken edit watch expression experience!

Damn!

Powered by Google App Engine
This is Rietveld 408576698