Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: util/mach/exc_client_variants_test.cc

Issue 700383007: Use implicit_cast<> instead of static_cast<> whenever possible (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: util/mach/exc_client_variants_test.cc
diff --git a/util/mach/exc_client_variants_test.cc b/util/mach/exc_client_variants_test.cc
index 0aa0882e5c747e83203464d68aaeae81ed8042cf..ec89fe6edecb4f811944d02a33eb63431e442e79 100644
--- a/util/mach/exc_client_variants_test.cc
+++ b/util/mach/exc_client_variants_test.cc
@@ -80,8 +80,8 @@ class TestExcClientVariants : public UniversalMachExcServer,
mach_exception_code_t expect_code = exception_code_;
mach_exception_subcode_t expect_subcode = exception_subcode_;
if ((behavior & MACH_EXCEPTION_CODES) == 0) {
- expect_code = static_cast<exception_data_type_t>(expect_code);
- expect_subcode = static_cast<exception_data_type_t>(expect_subcode);
+ expect_code = implicit_cast<exception_data_type_t>(expect_code);
+ expect_subcode = implicit_cast<exception_data_type_t>(expect_subcode);
}
EXPECT_EQ(exception_, exception);
@@ -101,7 +101,7 @@ class TestExcClientVariants : public UniversalMachExcServer,
EXPECT_EQ(exception_ + 10, *flavor);
EXPECT_EQ(MACHINE_THREAD_STATE_COUNT, old_state_count);
EXPECT_NE(nullptr, old_state);
- EXPECT_EQ(static_cast<mach_msg_type_number_t>(THREAD_STATE_MAX),
+ EXPECT_EQ(implicit_cast<mach_msg_type_number_t>(THREAD_STATE_MAX),
*new_state_count);
EXPECT_NE(nullptr, new_state);

Powered by Google App Engine
This is Rietveld 408576698