client/simple_string_dictionary.h - Issue 700383007: Use implicit_cast<> instead of static_cast<> whenever possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/simple_string_dictionary.h

Issue 700383007: Use implicit_cast<> instead of static_cast<> whenever possible (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: client/simple_string_dictionary.h

diff --git a/client/simple_string_dictionary.h b/client/simple_string_dictionary.h

index 4247da6993822f37e9b8d275b3af614b642eb0af..73eba626ce19b6871f856707eea94b06915bb8ec 100644

--- a/client/simple_string_dictionary.h

+++ b/client/simple_string_dictionary.h

@@ -231,7 +231,7 @@ class TSimpleStringDictionary {

entry->value[0] = '\0';

}

- DCHECK_EQ(GetEntryForKey(key), static_cast<Entry*>(nullptr));

+ DCHECK_EQ(GetEntryForKey(key), implicit_cast<Entry*>(nullptr));

Robert Sesek 2014/11/06 19:52:26 Is this cast necessary with nullptr?

Mark Mentovai 2014/11/06 21:44:35 Robert Sesek wrote:

}

//! \brief Returns a serialized form of the map.

« no previous file with comments | « client/capture_context_mac_test.cc ('k') | client/simulate_crash_mac.cc » ('j') | no next file with comments »