Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Unified Diff: util/mac/launchd.mm

Issue 700383007: Use implicit_cast<> instead of static_cast<> whenever possible (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: util/mac/launchd.mm
diff --git a/util/mac/launchd.mm b/util/mac/launchd.mm
index 1b7807570f5628996656b4565c8e7897985d3c31..f5aede54615df0510b85a87ea549bfca3f0a08ae 100644
--- a/util/mac/launchd.mm
+++ b/util/mac/launchd.mm
@@ -16,6 +16,7 @@
#import <Foundation/Foundation.h>
+#include "base/basictypes.h"
#include "base/mac/foundation_util.h"
#include "base/mac/scoped_launch_data.h"
#include "base/mac/scoped_cftyperef.h"
@@ -44,7 +45,7 @@ launch_data_t CFPropertyToLaunchData(CFPropertyListRef property_cf) {
}
CFPropertyListRef value_cf =
- static_cast<CFPropertyListRef>([dictionary_ns objectForKey:key]);
+ implicit_cast<CFPropertyListRef>([dictionary_ns objectForKey:key]);
launch_data_t value_launch = CFPropertyToLaunchData(value_cf);
if (!value_launch) {
return nullptr;
@@ -65,7 +66,7 @@ launch_data_t CFPropertyToLaunchData(CFPropertyListRef property_cf) {
for (id element_ns in array_ns) {
CFPropertyListRef element_cf =
- static_cast<CFPropertyListRef>(element_ns);
+ implicit_cast<CFPropertyListRef>(element_ns);
launch_data_t element_launch = CFPropertyToLaunchData(element_cf);
if (!element_launch) {
return nullptr;

Powered by Google App Engine
This is Rietveld 408576698