snapshot/mac/mach_o_image_reader.cc - Issue 700383007: Use implicit_cast<> instead of static_cast<> whenever possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: snapshot/mac/mach_o_image_reader.cc

Issue 700383007: Use implicit_cast<> instead of static_cast<> whenever possible (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: snapshot/mac/mach_o_image_reader.cc

diff --git a/snapshot/mac/mach_o_image_reader.cc b/snapshot/mac/mach_o_image_reader.cc

index 65dd3946be5bbd2aba9c0b940052c3d8f7ce761d..26f7138823b4057ee524b313a56ff33eb1a0c828 100644

--- a/snapshot/mac/mach_o_image_reader.cc

+++ b/snapshot/mac/mach_o_image_reader.cc

@@ -439,7 +439,7 @@ bool MachOImageReader::LookUpExternalDefinedSymbol(

uint32_t MachOImageReader::DylibVersion() const {

INITIALIZATION_STATE_DCHECK_VALID(initialized_);

- DCHECK_EQ(FileType(), static_cast<uint32_t>(MH_DYLIB));

+ DCHECK_EQ(FileType(), implicit_cast<uint32_t>(MH_DYLIB));

if (id_dylib_command_) {

return id_dylib_command_->dylib_current_version;

« client/simple_string_dictionary.h ('K') | « snapshot/cpu_context.cc ('k') | snapshot/mac/mach_o_image_reader_test.cc » ('j') | no next file with comments »