Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: snapshot/mac/mach_o_image_reader.cc

Issue 700383007: Use implicit_cast<> instead of static_cast<> whenever possible (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 421 matching lines...) Expand 10 before | Expand all | Expand 10 after
432 section->size) << module_info_; 432 section->size) << module_info_;
433 return false; 433 return false;
434 } 434 }
435 435
436 *value = slid_value; 436 *value = slid_value;
437 return true; 437 return true;
438 } 438 }
439 439
440 uint32_t MachOImageReader::DylibVersion() const { 440 uint32_t MachOImageReader::DylibVersion() const {
441 INITIALIZATION_STATE_DCHECK_VALID(initialized_); 441 INITIALIZATION_STATE_DCHECK_VALID(initialized_);
442 DCHECK_EQ(FileType(), static_cast<uint32_t>(MH_DYLIB)); 442 DCHECK_EQ(FileType(), implicit_cast<uint32_t>(MH_DYLIB));
443 443
444 if (id_dylib_command_) { 444 if (id_dylib_command_) {
445 return id_dylib_command_->dylib_current_version; 445 return id_dylib_command_->dylib_current_version;
446 } 446 }
447 447
448 // In case this was a weird dylib without an LC_ID_DYLIB command. 448 // In case this was a weird dylib without an LC_ID_DYLIB command.
449 return 0; 449 return 0;
450 } 450 }
451 451
452 void MachOImageReader::UUID(crashpad::UUID* uuid) const { 452 void MachOImageReader::UUID(crashpad::UUID* uuid) const {
(...skipping 209 matching lines...) Expand 10 before | Expand all | Expand 10 after
662 linkedit_segment, 662 linkedit_segment,
663 module_info_)) { 663 module_info_)) {
664 symbol_table_.reset(); 664 symbol_table_.reset();
665 return; 665 return;
666 } 666 }
667 667
668 symbol_table_initialized_.set_valid(); 668 symbol_table_initialized_.set_valid();
669 } 669 }
670 670
671 } // namespace crashpad 671 } // namespace crashpad
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698