Issue 7003100: Merge 88204 - Partially deprecate the old webstorePrivate.beginInstall method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7003100: Merge 88204 - Partially deprecate the old webstorePrivate.beginInstall method (Closed)

Created:
9 years, 6 months ago by asargent_no_longer_on_chrome

Modified:
9 years, 6 months ago

Reviewers:
asargent_no_longer_on_chrome

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/branches/782/src/

Visibility:
Public.

Description

Merge 88204 - Partially deprecate the old webstorePrivate.beginInstall method We are still allowing it to be used to do installs, but with this change it will no longer prevent the confirmation dialog from appearing. Once the web store completely transitions to use the newer beginInstallWithManifest2 method, we can remove beginInstall alltogether. BUG=75821 TEST=Installing an app/extension from the web store should cause an install confirmation prompt to appear after the item downloads. Review URL: http://codereview.chromium.org/7131001 TBR=asargent@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88606

Patch Set 1 #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -7 lines)			Patch
M	chrome/browser/extensions/crx_installer.cc	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/crx_installer_browsertest.cc	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_gallery_install_apitest.cc	View	2 chunks	+38 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_install_ui.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages