Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1507)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/extensions/crx_installer_browsertest.cc

Issue 7003100: Merge 88204 - Partially deprecate the old webstorePrivate.beginInstall method (Closed) Base URL: svn://svn.chromium.org/chrome/branches/782/src/
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/crx_installer.cc ('k') | chrome/browser/extensions/extension_gallery_install_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/crx_installer_browsertest.cc
===================================================================
--- chrome/browser/extensions/crx_installer_browsertest.cc (revision 88605)
+++ chrome/browser/extensions/crx_installer_browsertest.cc (working copy)
@@ -67,9 +67,10 @@
};
IN_PROC_BROWSER_TEST_F(ExtensionCrxInstallerTest, Whitelisting) {
- // A regular extension should give no prompt.
- EXPECT_FALSE(DidWhitelistInstallPrompt("good.crx",
- "ldnnhddmnhbkjipkidpdiheffobcpfmf"));
+ // We're deprecating this whitelist mechanism, but right now we just assert
+ // that it actually did prompt.
+ EXPECT_TRUE(DidWhitelistInstallPrompt("good.crx",
+ "ldnnhddmnhbkjipkidpdiheffobcpfmf"));
#if !defined(OS_CHROMEOS)
// An extension with NPAPI should give a prompt.
EXPECT_TRUE(DidWhitelistInstallPrompt("uitest/plugins.crx",
« no previous file with comments | « chrome/browser/extensions/crx_installer.cc ('k') | chrome/browser/extensions/extension_gallery_install_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698