Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 7131001: Partially deprecate the old webstorePrivate.beginInstall method (Closed)

Created:
9 years, 6 months ago by asargent_no_longer_on_chrome
Modified:
9 years, 6 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Partially deprecate the old webstorePrivate.beginInstall method We are still allowing it to be used to do installs, but with this change it will no longer prevent the confirmation dialog from appearing. Once the web store completely transitions to use the newer beginInstallWithManifest2 method, we can remove beginInstall alltogether. BUG=75821 TEST=Installing an app/extension from the web store should cause an install confirmation prompt to appear after the item downloads. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88204

Patch Set 1 #

Total comments: 1

Patch Set 2 : moved observing to helper object #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -7 lines) Patch
M chrome/browser/extensions/crx_installer.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/extensions/crx_installer_browsertest.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_gallery_install_apitest.cc View 1 2 chunks +38 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_install_ui.h View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
asargent_no_longer_on_chrome
9 years, 6 months ago (2011-06-07 17:04:51 UTC) #1
Matt Perry
LGTM except for below http://codereview.chromium.org/7131001/diff/1/chrome/browser/extensions/extension_gallery_install_apitest.cc File chrome/browser/extensions/extension_gallery_install_apitest.cc (right): http://codereview.chromium.org/7131001/diff/1/chrome/browser/extensions/extension_gallery_install_apitest.cc#newcode55 chrome/browser/extensions/extension_gallery_install_apitest.cc:55: virtual void Observe(NotificationType type, Don't ...
9 years, 6 months ago (2011-06-07 18:03:30 UTC) #2
asargent_no_longer_on_chrome
In order to avoid conflicts with the observe of the parent class, I moved the ...
9 years, 6 months ago (2011-06-07 18:40:32 UTC) #3
Matt Perry
9 years, 6 months ago (2011-06-07 18:54:18 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698