More consistently use auto for emit*, nullptr in asm code.

More consistently use auto for emit*, nullptr in asm code.

More consistently use auto while doing llvm::dyn_cast/cast in the emit
and emitIAS routines.

BUG=none
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=359c03605aefd30b884bd00a8582e53525a612e3

[jvoung (off chromium), 2014-11-04 17:05:41]

jvoung@chromium.org changed reviewers:
+ kschimpf@chromium.org, stichnot@chromium.org

[Jim Stichnoth, 2014-11-04 17:41:25]

LGTM.

As long as you're doing this :) , I have some more nits that could be addressed.
  - const auto when possible
  - NULL/nullptr consistency
  - use "Var" in the variable name when it is the result of
llvm::*cast<Variable>(*)

https://codereview.chromium.org/699923002/diff/20001/src/IceInstX8632.cpp
File src/IceInstX8632.cpp (right):

https://codereview.chromium.org/699923002/diff/20001/src/IceInstX8632.cpp#new...
src/IceInstX8632.cpp:353: if (!LastFixup) {
Using !ptr here, and ptr==nullptr below.  Make it consistent style?  (but I
can't say which style should be preferred...)

https://codereview.chromium.org/699923002/diff/20001/src/IceInstX8632.cpp#new...
src/IceInstX8632.cpp:385: assert(LastFixup == nullptr || LastFixup->position()
== LastFixupLoc);
Does it make sense to change all NULL-->nullptr starting from the "Dump
routines" comment?

https://codereview.chromium.org/699923002/diff/20001/src/IceInstX8632.cpp#new...
src/IceInstX8632.cpp:538: if (auto CallTarget =
llvm::dyn_cast<ConstantRelocatable>(getCallTarget())) {
const auto?

https://codereview.chromium.org/699923002/diff/20001/src/IceInstX8632.cpp#new...
src/IceInstX8632.cpp:768: const auto Src1 = llvm::cast<Variable>(Src1Op);
rename to SrcVar1?

https://codereview.chromium.org/699923002/diff/20001/src/IceInstX8632.cpp#new...
src/IceInstX8632.cpp:934: if (SrcVar == NULL)
nullptr like elsewhere?

https://codereview.chromium.org/699923002/diff/20001/src/IceInstX8632.cpp#new...
src/IceInstX8632.cpp:1351: const auto Src0 =
llvm::dyn_cast<Variable>(getSrc(0));
rename Src0Var or SrcVar?

https://codereview.chromium.org/699923002/diff/20001/src/IceInstX8632.cpp#new...
src/IceInstX8632.cpp:1375: const auto Src0 =
llvm::dyn_cast<Variable>(getSrc(0));
rename Src0Var or SrcVar?

https://codereview.chromium.org/699923002/diff/20001/src/IceInstX8632.cpp#new...
src/IceInstX8632.cpp:1848: const auto Src0 = llvm::cast<Variable>(getSrc(0));
rename Src0Var or SrcVar?

https://codereview.chromium.org/699923002/diff/20001/src/IceInstX8632.cpp#new...
src/IceInstX8632.cpp:2054: if (const auto VSrc0 =
llvm::dyn_cast<Variable>(Src0)) {
rename Src0Var or SrcVar?

https://codereview.chromium.org/699923002/diff/20001/src/IceInstX8632.cpp#new...
src/IceInstX8632.cpp:2508: if (const auto VSrc1 =
llvm::dyn_cast<Variable>(Src1)) {
rename Src1Var?

https://codereview.chromium.org/699923002/diff/20001/src/IceInstX8632.cpp#new...
src/IceInstX8632.cpp:2763: } else if (auto CI =
llvm::dyn_cast<ConstantInteger32>(Offset)) {
const auto?

https://codereview.chromium.org/699923002/diff/20001/src/IceInstX8632.cpp#new...
src/IceInstX8632.cpp:2767: } else if (auto CR =
llvm::dyn_cast<ConstantRelocatable>(Offset)) {
const auto?

[jvoung (off chromium), 2014-11-04 18:22:35]

https://codereview.chromium.org/699923002/diff/20001/src/IceInstX8632.cpp
File src/IceInstX8632.cpp (right):

https://codereview.chromium.org/699923002/diff/20001/src/IceInstX8632.cpp#new...
src/IceInstX8632.cpp:353: if (!LastFixup) {
On 2014/11/04 17:41:25, stichnot wrote:
> Using !ptr here, and ptr==nullptr below.  Make it consistent style?  (but I
> can't say which style should be preferred...)

Yep -- no strong preference, but I'll just go with !ptr since it's shorter /
less NULL vs nullptr. I guess it's not as nice in terms of type checking though
=/

https://codereview.chromium.org/699923002/diff/20001/src/IceInstX8632.cpp#new...
src/IceInstX8632.cpp:385: assert(LastFixup == nullptr || LastFixup->position()
== LastFixupLoc);
On 2014/11/04 17:41:25, stichnot wrote:
> Does it make sense to change all NULL-->nullptr starting from the "Dump
> routines" comment?

Most of them are checks against NULL, so I ended up changing it to the !ptr
style.

https://codereview.chromium.org/699923002/diff/20001/src/IceInstX8632.cpp#new...
src/IceInstX8632.cpp:538: if (auto CallTarget =
llvm::dyn_cast<ConstantRelocatable>(getCallTarget())) {
On 2014/11/04 17:41:25, stichnot wrote:
> const auto?

Done.

https://codereview.chromium.org/699923002/diff/20001/src/IceInstX8632.cpp#new...
src/IceInstX8632.cpp:768: const auto Src1 = llvm::cast<Variable>(Src1Op);
On 2014/11/04 17:41:25, stichnot wrote:
> rename to SrcVar1?

Done.

https://codereview.chromium.org/699923002/diff/20001/src/IceInstX8632.cpp#new...
src/IceInstX8632.cpp:934: if (SrcVar == NULL)
On 2014/11/04 17:41:25, stichnot wrote:
> nullptr like elsewhere?

Done.

https://codereview.chromium.org/699923002/diff/20001/src/IceInstX8632.cpp#new...
src/IceInstX8632.cpp:1351: const auto Src0 =
llvm::dyn_cast<Variable>(getSrc(0));
On 2014/11/04 17:41:25, stichnot wrote:
> rename Src0Var or SrcVar?

Done.

https://codereview.chromium.org/699923002/diff/20001/src/IceInstX8632.cpp#new...
src/IceInstX8632.cpp:1375: const auto Src0 =
llvm::dyn_cast<Variable>(getSrc(0));
On 2014/11/04 17:41:25, stichnot wrote:
> rename Src0Var or SrcVar?

Done.

https://codereview.chromium.org/699923002/diff/20001/src/IceInstX8632.cpp#new...
src/IceInstX8632.cpp:1848: const auto Src0 = llvm::cast<Variable>(getSrc(0));
On 2014/11/04 17:41:25, stichnot wrote:
> rename Src0Var or SrcVar?

Done.

https://codereview.chromium.org/699923002/diff/20001/src/IceInstX8632.cpp#new...
src/IceInstX8632.cpp:2054: if (const auto VSrc0 =
llvm::dyn_cast<Variable>(Src0)) {
On 2014/11/04 17:41:25, stichnot wrote:
> rename Src0Var or SrcVar?

Done.

https://codereview.chromium.org/699923002/diff/20001/src/IceInstX8632.cpp#new...
src/IceInstX8632.cpp:2508: if (const auto VSrc1 =
llvm::dyn_cast<Variable>(Src1)) {
On 2014/11/04 17:41:25, stichnot wrote:
> rename Src1Var?

Done.

https://codereview.chromium.org/699923002/diff/20001/src/IceInstX8632.cpp#new...
src/IceInstX8632.cpp:2763: } else if (auto CI =
llvm::dyn_cast<ConstantInteger32>(Offset)) {
On 2014/11/04 17:41:25, stichnot wrote:
> const auto?

Done.

https://codereview.chromium.org/699923002/diff/20001/src/IceInstX8632.cpp#new...
src/IceInstX8632.cpp:2767: } else if (auto CR =
llvm::dyn_cast<ConstantRelocatable>(Offset)) {
On 2014/11/04 17:41:25, stichnot wrote:
> const auto?

Done.

[jvoung (off chromium), 2014-11-04 18:40:08]

Committed patchset #3 (id:40001) manually as
359c03605aefd30b884bd00a8582e53525a612e3 (presubmit successful).