MacViews: Add a CreateChromeConstrainedWindowViewsClient stub

chrome/browser/ui/views/chrome_constrained_window_views_client.cc

Index: chrome/browser/ui/views/chrome_constrained_window_views_client.cc
diff --git a/chrome/browser/ui/views/chrome_constrained_window_views_client.cc b/chrome/browser/ui/views/chrome_constrained_window_views_client.cc
index aea31f9736f6b596937eaef9b07a625dbcb1dfea..37ba17e040de804e11466ed9f5d917c1cfe2d820 100644
--- a/chrome/browser/ui/views/chrome_constrained_window_views_client.cc
+++ b/chrome/browser/ui/views/chrome_constrained_window_views_client.cc
@@ -26,7 +26,7 @@ class ChromeConstrainedWindowViewsClient
         guest_view->embedder_web_contents() : initiator_web_contents;
   }
   web_modal::ModalDialogHost* GetModalDialogHost(
-      gfx::NativeWindow parent) override {
+      gfx::NativeView parent) override {
     // Get the browser dialog management and hosting components from |parent|.
     Browser* browser = chrome::FindBrowserWithWindow(parent);

[tapted, 2014/11/03 07:19:04]

note this line only works on aura currently, but it needs to be fixed higher up.
WebModal dialogs are owned by a WebContents, and only the WebContents for the
active tab on Mac have an associated NSWindow. They all have an NSView, but
there's no FindBrowser* for that.

The fix is probably that TODO already at constrained_window_views.cc:154
"TODO(gbillock): Replace this with PopupManager calls". which I think will
remove the need for GetModalDialogHost() altogether. That TODO is probably made
a lot easier by MacViews, and so the circle is complete :)

But that's all for another day..

[msw, 2014/11/03 19:20:32]

Acknowledged.

     if (browser) {