MacViews: Add a CreateChromeConstrainedWindowViewsClient stub

chrome/browser/ui/views/chrome_constrained_window_views_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/chrome_constrained_window_views_client.h"
 
 #include "chrome/browser/ui/browser_finder.h"
 #include "components/web_modal/web_contents_modal_dialog_host.h"
 #include "extensions/browser/guest_view/guest_view_base.h"
 
 namespace {
 
 class ChromeConstrainedWindowViewsClient
     : public ConstrainedWindowViewsClient {
  public:
   ChromeConstrainedWindowViewsClient() {}
   ~ChromeConstrainedWindowViewsClient() override {}
 
  private:
   // ConstrainedWindowViewsClient:
   content::WebContents* GetEmbedderWebContents(
       content::WebContents* initiator_web_contents) override {
     extensions::GuestViewBase* guest_view =
         extensions::GuestViewBase::FromWebContents(initiator_web_contents);
     return guest_view && guest_view->embedder_web_contents() ?
         guest_view->embedder_web_contents() : initiator_web_contents;
   }
   web_modal::ModalDialogHost* GetModalDialogHost(
-      gfx::NativeWindow parent) override {
+      gfx::NativeView parent) override {
     // Get the browser dialog management and hosting components from |parent|.
     Browser* browser = chrome::FindBrowserWithWindow(parent);

[tapted, 2014/11/03 07:19:04]

note this line only works on aura currently, but it needs to be fixed higher up.
WebModal dialogs are owned by a WebContents, and only the WebContents for the
active tab on Mac have an associated NSWindow. They all have an NSView, but
there's no FindBrowser* for that.

The fix is probably that TODO already at constrained_window_views.cc:154
"TODO(gbillock): Replace this with PopupManager calls". which I think will
remove the need for GetModalDialogHost() altogether. That TODO is probably made
a lot easier by MacViews, and so the circle is complete :)

But that's all for another day..

[msw, 2014/11/03 19:20:32]

Acknowledged.

     if (browser) {
       ChromeWebModalDialogManagerDelegate* manager = browser;
       return manager->GetWebContentsModalDialogHost();
     }
     return nullptr;
   }
 
   DISALLOW_COPY_AND_ASSIGN(ChromeConstrainedWindowViewsClient);
 };
 
 }  // namespace
 
 scoped_ptr<ConstrainedWindowViewsClient>
 CreateChromeConstrainedWindowViewsClient() {
   return make_scoped_ptr(new ChromeConstrainedWindowViewsClient);
 }