chrome/browser/ui/BUILD.gn - Issue 699553002: MacViews: Add a CreateChromeConstrainedWindowViewsClient stub

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/BUILD.gn

Issue 699553002: MacViews: Add a CreateChromeConstrainedWindowViewsClient stub (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: don't forget gn Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/views/chrome_constrained_window_views_client.cc » ('j') | chrome/browser/ui/views/chrome_constrained_window_views_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/BUILD.gn

diff --git a/chrome/browser/ui/BUILD.gn b/chrome/browser/ui/BUILD.gn

index c0af2d707ec5e98541d7af2ef07d493cff05766f..23f390985b18504aa2c12f4cdcc59008511756a4 100644

--- a/chrome/browser/ui/BUILD.gn

+++ b/chrome/browser/ui/BUILD.gn

@@ -218,6 +218,7 @@ static_library("ui") {

if (toolkit_views) {

sources += rebase_path(gypi_values.chrome_browser_ui_views_sources,

".", "//chrome")

+ deps += [ "//components/constrained_window" ]

if (!is_chromeos) {

sources += rebase_path(

gypi_values.chrome_browser_ui_views_non_chromeos_sources,

@@ -228,7 +229,6 @@ static_library("ui") {

gypi_values.chrome_browser_ui_views_non_mac_sources,

".", "//chrome")

deps += [

- "//components/constrained_window",

"//extensions/components/native_app_window",

]

}