Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Unified Diff: minidump/minidump_rva_list_writer.h

Issue 699313007: minidump: Use the crashpad::internal namespace more appropriately (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « minidump/minidump_module_crashpad_info_writer_test.cc ('k') | minidump/minidump_rva_list_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: minidump/minidump_rva_list_writer.h
diff --git a/minidump/minidump_rva_list_writer.h b/minidump/minidump_rva_list_writer.h
index 5d27794dc439b0a12e4d21b2f920dab5ee65dbde..257f2c0cd78175cde8cf87cbb7b6f204a35d9202 100644
--- a/minidump/minidump_rva_list_writer.h
+++ b/minidump/minidump_rva_list_writer.h
@@ -27,24 +27,24 @@
#include "util/stdlib/pointer_container.h"
namespace crashpad {
+namespace internal {
//! \brief The writer for a MinidumpRVAList object in a minidump file,
//! containing a list of ::RVA pointers.
-class MinidumpRVAListWriter : public internal::MinidumpWritable {
+class MinidumpRVAListWriter : public MinidumpWritable {
protected:
MinidumpRVAListWriter();
~MinidumpRVAListWriter() override;
- //! \brief Adds an ::RVA referencing an internal::MinidumpWritable to the
+ //! \brief Adds an ::RVA referencing an MinidumpWritable to the
//! MinidumpRVAList.
//!
//! This object takes ownership of \a child and becomes its parent in the
- //! overall tree of internal::MinidumpWritable objects.
+ //! overall tree of MinidumpWritable objects.
//!
//! To provide type-correctness, subclasses are expected to provide a public
//! method that accepts a `scoped_ptr`-wrapped argument of the proper
- //! internal::MinidumpWritable subclass, and call this method with that
- //! argument.
+ //! MinidumpWritable subclass, and call this method with that argument.
//!
//! \note Valid in #kStateMutable.
void AddChild(scoped_ptr<MinidumpWritable> child);
@@ -73,6 +73,7 @@ class MinidumpRVAListWriter : public internal::MinidumpWritable {
DISALLOW_COPY_AND_ASSIGN(MinidumpRVAListWriter);
};
+} // namespace internal
} // namespace crashpad
#endif // CRASHPAD_MINIDUMP_RVA_LIST_WRITER_H_
« no previous file with comments | « minidump/minidump_module_crashpad_info_writer_test.cc ('k') | minidump/minidump_rva_list_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698