Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2827)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/sys_info_unittest.cc

Issue 699173002: UMA: Set Hardware model class on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/sys_info_mac.cc ('K') | « base/sys_info_mac.cc ('k') | components/metrics/metrics_log.cc » ('j') | components/metrics/metrics_log.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/sys_info_unittest.cc
diff --git a/base/sys_info_unittest.cc b/base/sys_info_unittest.cc
index 29409eed340c0af2f93e8419b054b04fbd0eca1e..ee0ccd8219accb706022ea058e45bb9b6905c9a0 100644
--- a/base/sys_info_unittest.cc
+++ b/base/sys_info_unittest.cc
@@ -65,6 +65,14 @@ TEST_F(SysInfoTest, Uptime) {
EXPECT_GT(up_time_2, up_time_1);
}
+#if defined(OS_MACOSX)
+TEST_F(SysInfoTest, HardwareModelName) {
+ std::string hardware_model =
+ base::SysInfo::HardwareModelName();
Mark Mentovai 2014/11/04 14:36:37 This would definitely fit on one line.
jeremy 2014/11/05 05:38:06 Done.
+ EXPECT_GT(hardware_model.length(), 0U);
Mark Mentovai 2014/11/04 14:36:37 You can just EXPECT_FALSE(hardware_model.empty()).
jeremy 2014/11/05 05:38:06 Done.
+}
+#endif
+
#if defined(OS_CHROMEOS)
TEST_F(SysInfoTest, GoogleChromeOSVersionNumbers) {
« base/sys_info_mac.cc ('K') | « base/sys_info_mac.cc ('k') | components/metrics/metrics_log.cc » ('j') | components/metrics/metrics_log.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698