UMA: Set Hardware model class on Mac.

components/metrics/metrics_log.cc

Index: components/metrics/metrics_log.cc
diff --git a/components/metrics/metrics_log.cc b/components/metrics/metrics_log.cc
index 8764a739fcd6af29cff51e3f6f6022fd16bcbe2b..4c4a1b0bc03423fdf87c03a19ce60f8975341494 100644
--- a/components/metrics/metrics_log.cc
+++ b/components/metrics/metrics_log.cc
@@ -351,8 +351,12 @@ void MetricsLog::RecordEnvironment(
 
   SystemProfileProto::Hardware* hardware = system_profile->mutable_hardware();
 
+#if defined(OS_MACOSX)
+  hardware->set_hardware_class(base::SysInfo::HardwareModelName());
+#else
   // By default, the hardware class is empty (i.e., unknown).
   hardware->set_hardware_class(std::string());
+#endif

[Alexei Svitkine (slow), 2014/11/04 16:22:12]

FWIW, I'd prefer if we can avoid ifdefs in this code.

How about providing an implementation of base::SysInfo::HardwareModelName() on
all platforms (i.e. contrary to Mark's comment) that returns an empty string on
everything except for the Mac implementation. Document that the empty string
means unknown. Then, this code can simply call:

  hardware->set_hardware_class(base::SysInfo::HardwareModelName());

Without any ifdefs. WDYT?

[jeremy, 2014/11/05 05:38:06]

Done.

 
   hardware->set_cpu_architecture(base::SysInfo::OperatingSystemArchitecture());
   hardware->set_system_ram_mb(base::SysInfo::AmountOfPhysicalMemoryMB());