UMA: Set Hardware model class on Mac.

base/sys_info_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/environment.h"
 #include "base/files/file_util.h"
 #include "base/sys_info.h"
 #include "base/threading/platform_thread.h"
 #include "base/time/time.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 47 matching lines @@
 TEST_F(SysInfoTest, Uptime) {
   int64 up_time_1 = base::SysInfo::Uptime();
   // UpTime() is implemented internally using TimeTicks::Now(), which documents
   // system resolution as being 1-15ms. Sleep a little longer than that.
   base::PlatformThread::Sleep(base::TimeDelta::FromMilliseconds(20));
   int64 up_time_2 = base::SysInfo::Uptime();
   EXPECT_GT(up_time_1, 0);
   EXPECT_GT(up_time_2, up_time_1);
 }
 
+#if defined(OS_MACOSX)
+TEST_F(SysInfoTest, HardwareModelName) {
+  std::string hardware_model =
+      base::SysInfo::HardwareModelName();

[Mark Mentovai, 2014/11/04 14:36:37]

This would definitely fit on one line.

[jeremy, 2014/11/05 05:38:06]

Done.

+  EXPECT_GT(hardware_model.length(), 0U);

[Mark Mentovai, 2014/11/04 14:36:37]

You can just EXPECT_FALSE(hardware_model.empty()).

[jeremy, 2014/11/05 05:38:06]

Done.

+}
+#endif
+
 #if defined(OS_CHROMEOS)
 
 TEST_F(SysInfoTest, GoogleChromeOSVersionNumbers) {
   int32 os_major_version = -1;
   int32 os_minor_version = -1;
   int32 os_bugfix_version = -1;
   const char kLsbRelease[] =
       "FOO=1234123.34.5\n"
       "CHROMEOS_RELEASE_VERSION=1.2.3.4\n";
   base::SysInfo::SetChromeOSVersionInfoForTest(kLsbRelease, base::Time());
@@ skipping 61 matching lines @@
   base::SysInfo::SetChromeOSVersionInfoForTest(kLsbRelease2, base::Time());
   EXPECT_TRUE(base::SysInfo::IsRunningOnChromeOS());
 
   const char kLsbRelease3[] =
       "CHROMEOS_RELEASE_NAME=Chromium OS\n";
   base::SysInfo::SetChromeOSVersionInfoForTest(kLsbRelease3, base::Time());
   EXPECT_TRUE(base::SysInfo::IsRunningOnChromeOS());
 }
 
 #endif  // OS_CHROMEOS