Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 6976040: Revert 86914 - Move a bunch of functions from Window onto Widget. (Closed)

Created:
9 years, 7 months ago by wtc
Modified:
9 years, 7 months ago
CC:
chromium-reviews, rharrison, davemoore+watch_chromium.org, nkostylev+cc_chromium.org
Visibility:
Public.

Description

Revert 86914 - Move a bunch of functions from Window onto Widget. Many tests in browser_tests crashed with a LOG(DFATAL) message on Chrome OS: [28862:28862:0526/153905:3290241082989:FATAL:browser_main.cc(955)] GLib-GObject: invalid (NULL) pointer instance Backtrace: base::debug::StackTrace::StackTrace() [0x33308d6] logging::LogMessage::~LogMessage() [0x334df2e] (anonymous namespace)::GLibLogHandler() [0x7c7d45] 0x2ab2a37a7fb9 0x2ab2a37a83d3 0x2ab2a313302a 0x2ab2a31315c5 views::NativeWidgetGtk::InitNativeWidget() [0x1a30dcf] views::Widget::Init() [0x1a37fa7] NativeTabContentsViewGtk::InitNativeTabContentsView() [0x10c6b83] TabContentsViewViews::CreateView() [0x397ac46] TabContents::TabContents() [0x1501e09] Browser::TabContentsFactory() [0xc84725] browser::Navigate() [0xc954c7] Browser::AddSelectedTabWithURL() [0xc76d9e] (anonymous namespace)::InitializeBrowser() [0x70be3d] InProcessBrowserTest::CreateBrowser() [0x70d178] InProcessBrowserTest::RunTestOnMainThreadLoop() [0x70d34a] [...snipped...] BUG=72040 TEST=none Review URL: http://codereview.chromium.org/7075019 R=msw@chromium.org TBR=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86939

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+421 lines, -322 lines) Patch
M chrome/browser/chromeos/login/background_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/eula_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/network_login_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/status/network_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/first_run_search_engine_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/task_manager_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/widget/native_widget.h View 1 chunk +2 lines, -9 lines 0 comments Download
M views/widget/native_widget_gtk.h View 3 chunks +2 lines, -15 lines 0 comments Download
M views/widget/native_widget_gtk.cc View 5 chunks +12 lines, -52 lines 0 comments Download
M views/widget/native_widget_views.h View 1 chunk +2 lines, -9 lines 0 comments Download
M views/widget/native_widget_views.cc View 1 chunk +5 lines, -35 lines 0 comments Download
M views/widget/native_widget_win.h View 2 chunks +2 lines, -12 lines 0 comments Download
M views/widget/native_widget_win.cc View 2 chunks +9 lines, -46 lines 0 comments Download
M views/widget/widget.h View 3 chunks +8 lines, -34 lines 0 comments Download
M views/widget/widget.cc View 1 chunk +4 lines, -32 lines 0 comments Download
M views/window/native_window.h View 1 chunk +12 lines, -0 lines 0 comments Download
M views/window/native_window_gtk.h View 4 chunks +20 lines, -5 lines 0 comments Download
M views/window/native_window_gtk.cc View 7 chunks +71 lines, -17 lines 0 comments Download
M views/window/native_window_views.h View 1 chunk +12 lines, -0 lines 0 comments Download
M views/window/native_window_views.cc View 3 chunks +49 lines, -0 lines 0 comments Download
M views/window/native_window_win.h View 2 chunks +15 lines, -3 lines 0 comments Download
M views/window/native_window_win.cc View 5 chunks +61 lines, -9 lines 0 comments Download
M views/window/window.h View 4 chunks +50 lines, -4 lines 0 comments Download
M views/window/window.cc View 4 chunks +73 lines, -28 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
wtc
9 years, 7 months ago (2011-05-27 00:12:22 UTC) #1
wtc
9 years, 7 months ago (2011-05-27 00:14:00 UTC) #2
msw
9 years, 7 months ago (2011-05-27 00:20:42 UTC) #3
On 2011/05/27 00:14:00, wtc wrote:

LGTM :[

Powered by Google App Engine
This is Rietveld 408576698